[xabg2]

Description

Clicking a photo in the gallery now opens it full size in the viewer, and videos open there to be played. The previous and next arrows move through the photos in the same order as the gallery, newest first, across days and devices.

Downloading from the viewer, with its download button or from its menu, also downloads the related files of the item: the video of a Live Photo, or every photo of a burst. A single photo is downloaded on its own. The viewer menu only offers to download, since renaming or moving photos would break the folders the mobile app backs up to.

Opening a photo keeps the thumbnail made by the phone instead of generating and uploading a new one.

The timeline file was split into smaller pieces (day title, month error, loading placeholders and layout helpers), with no change in behaviour.

Related Issues

Jira: PB-7049 (parent PB-6876)

Related Pull Requests

• Stacked on [PB-7047]: feat/group Live Photos and bursts #2309, which is stacked on [PB-7047]: feat/pace thumbnail downloads #2308, [PB-7047]: feat/keep loading older months while scrolling #2304, [PB-7047]: feat/show the thumbnails of the photos on screen #2303 and [PB-7047]: feat/only draw the photos on screen #2302; merge them in order.

Checklist

• Changes have been tested locally.
• Unit tests have been written or updated as necessary.
• The code adheres to the repository's coding standards.
• Relevant documentation has been added or updated.
• No new warnings or errors have been introduced.
• SonarCloud issues have been reviewed and addressed.
• QA Passed

Testing Process

• Unit tests cover opening a photo full size, opening a video as playable, moving to the next and previous photos in gallery order across days and devices, downloading a Live Photo with its video, a burst with all its photos (also from other days), a single photo on its own, a viewer menu that only offers to download, and opening a photo without uploading a new thumbnail.
• Checked locally in the browser: opening photos full size, the arrows following the gallery order and the menu with only Download. Video playback could not be checked locally because the video streaming player returns 503 on the dev server.

Additional Notes

The page is still not linked from the sidebar.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 6556d65e-25be-4183-a757-b35957241d0f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[cloudflare-workers-and-pages]

Deploying drive-web with    Cloudflare Pages

Latest commit:	075f652
Status:	✅  Deploy successful!
Preview URL:	https://48a4e77c.drive-web.pages.dev
Branch Preview URL:	https://feat-pb-7049-photos-open-in.drive-web.pages.dev

View logs

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud