[xabg2]

Description

Photos can now be selected to download several at once. Each photo shows a checkbox when the pointer is over it, and each day title has one to select or unselect the whole day, including the photos of that day that are not on screen yet. Once something is selected, clicking a photo adds it to the selection or removes it instead of opening the viewer.

While photos are selected, the Photos header shows how many are selected and a Download action instead of the title and filters. Pressing Esc or the close button clears the selection.

Downloading several photos produces a single ZIP, in the same order as the gallery. The video of a Live Photo and every photo of a burst are downloaded with them.

Related Issues

Jira: PB-7050 (parent PB-6876)

Related Pull Requests

• Stacked on [PB-7049]: feat/open photos in the viewer #2311, which is stacked on [PB-7047]: feat/group Live Photos and bursts #2309, [PB-7047]: feat/pace thumbnail downloads #2308, [PB-7047]: feat/keep loading older months while scrolling #2304, [PB-7047]: feat/show the thumbnails of the photos on screen #2303 and [PB-7047]: feat/only draw the photos on screen #2302; merge them in order.

Checklist

• Changes have been tested locally.
• Unit tests have been written or updated as necessary.
• The code adheres to the repository's coding standards.
• Relevant documentation has been added or updated.
• No new warnings or errors have been introduced.
• SonarCloud issues have been reviewed and addressed.
• QA Passed

Testing Process

• Unit tests cover selecting photos one by one and by day (also partly selected days), the header showing the count, clicking a photo while selecting, unselecting, clearing with Esc right after ticking a checkbox and with the close button, downloading in gallery order as one ZIP, Live Photos with their video, and a day with hundreds of photos.
• Checked locally in the browser: checkboxes on hover, the partly selected day, the selected border, the header with the count and Download, Esc and the close button.

Additional Notes

The page is still not linked from the sidebar. Moving selected photos to the trash comes in the next PR, as another action in the same header.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 4121f324-2c8f-4e6a-924e-04ad9c1b0121

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[cloudflare-workers-and-pages]

Deploying drive-web with    Cloudflare Pages

Latest commit:	0d23174
Status:	⚡️  Build in progress...

View logs

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud