Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
Deploying drive-web with
|
| Latest commit: |
6a7c36d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6c13c1df.drive-web.pages.dev |
| Branch Preview URL: | https://feat-pb-7050-photos-move-to.drive-web.pages.dev |
…oad' into feat/PB-7050-photos-move-to-trash # Conflicts: # src/views/Photos/components/PhotosViewer.tsx
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Selected photos can now be moved to the trash from the Photos header, next to Download. A photo can also be moved to the trash from the viewer, from its menu or with the same key as in Drive, which closes the viewer. The video of a Live Photo and every photo of a burst go to the trash with it.
It works like Drive: there is no confirmation, the photos leave the gallery right away and the notification offers Undo. If every photo loaded so far is trashed, the previous month is shown instead of the empty state. If moving to the trash fails, the photos stay in the gallery and stay selected.
Undo now puts every item back in the folder it came from. Before, all of them went back to the folder of the first one; for Photos that would have mixed the day folders the mobile app relies on. In Drive nothing changes when the items come from the same folder.
Related Issues
Jira: PB-7050 (parent PB-6876)
Related Pull Requests
Checklist
Testing Process
Additional Notes
The page is still not linked from the sidebar.