[xabg2]

Description

The device filter in Photos now ends with "Manage devices", which opens the list of devices that back up their photos. Each device can be deleted from there. Before anything is deleted, a confirmation warns that every photo and video backed up from that device will be deleted permanently.

Once a device is deleted, it leaves the list, its photos leave the gallery and the device filter goes back to "All devices". If the device had already been deleted elsewhere, it is removed from the list as well, with a message saying so. If the deletion fails, the device and its photos stay, and an error is shown.

The device filter is now shown as soon as there is one device (before, it only appeared with two or more), so users with a single phone can also manage it.

Related Issues

Jira: PB-7051 (parent PB-6876)

Related Pull Requests

• Stacked on [PB-7050]: feat/move photos to the trash #2316, which is stacked on [PB-7050]: feat/select photos and download them #2315, [PB-7049]: feat/open photos in the viewer #2311, [PB-7047]: feat/group Live Photos and bursts #2309, [PB-7047]: feat/pace thumbnail downloads #2308, [PB-7047]: feat/keep loading older months while scrolling #2304, [PB-7047]: feat/show the thumbnails of the photos on screen #2303 and [PB-7047]: feat/only draw the photos on screen #2302; merge them in order.

Checklist

• Changes have been tested locally.
• Unit tests have been written or updated as necessary.
• The code adheres to the repository's coding standards.
• Relevant documentation has been added or updated.
• No new warnings or errors have been introduced.
• SonarCloud issues have been reviewed and addressed.
• QA Passed

Testing Process

• Unit tests cover the filter with a single device, opening the list, the confirmation and cancelling it, deleting a device (its photos leave the gallery and the filter goes back to all devices), a device that no longer exists, a failed deletion, the confirmation not closing while the deletion is in progress, and deleting the last device.
• Checked locally in the browser: "Manage devices" in the filter with one device, the list, the confirmation and cancelling it. Deleting a real device is still to be checked.

Additional Notes

The page is still not linked from the sidebar. The device name is shown as the mobile app saves it, model plus device identifier.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 1192f9b9-02c7-4a46-8e26-34e014e2586a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[cloudflare-workers-and-pages]

Deploying drive-web with    Cloudflare Pages

Latest commit:	a113ccb
Status:	✅  Deploy successful!
Preview URL:	https://11f7fd50.drive-web.pages.dev
Branch Preview URL:	https://feat-pb-7051-photos-manage-d.drive-web.pages.dev

View logs

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud