Repository navigation
Reject unsupported URP upscalers in HDRP - #35
Merged
Merged
Conversation
This was referenced Oct 20, 2026
[Medium impact] The PR appears safe to merge. SummaryPreserves the requested upscaler value instead of clamping it into HDRP's supported range.
Reviews (1) · Last reviewed commit: "Reject unsupported URP upscalers in HDRP" · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject URP-only FSR1/STP settings when applying HDRP graphics configuration so they cannot accidentally select another upscaler.
Validation: coordinated Linux standalone build succeeded; 31 Unity EditMode tests passed. Cold and warm T2 loading completed without an Intel GPU timeout; warm cache loading took 2.1 seconds.
Part of the coordinated
fix/urp-player-gpu-cachechanges across the engine, player, URP/HDRP adapters, PinMAME, and URP player project.Coordinated PRs: