Skip to content

Anchor PinMAME time fences to simulation start - #46

Merged
freezy merged 1 commit into
masterfrom
fix/urp-player-gpu-cache
Oct 20, 2026
Merged

freezy merged 1 commit into
masterfrom
fix/urp-player-gpu-cache

Conversation

@freezy

@freezy freezy commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Anchor native ROM time fences to the active simulation start, preventing accelerated ROM execution after loading a table in the standalone player.

Validation: four PinMAME time-fence tests passed; coordinated Linux standalone build and T2 loading succeeded.

Part of the coordinated fix/urp-player-gpu-cache changes across the engine, player, URP/HDRP adapters, PinMAME, and URP player project.

Coordinated PRs:

@greptile-apps

greptile-apps Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Anchors PinMAME time fences to the first active simulation tick instead of the application's elapsed time.

  • Each ROM’s time fence starts with its simulation.

No actionable issues were found.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Start or retry] --> B[Reset clock and set fence to 0.01]
  B --> C[First active simulation tick records origin]
  C --> D[Later ticks use elapsed time plus 0.01]
  D --> E[Keep fence at least 0.01]
  F[Shutdown] --> G[Disable fence under the same lock]
  G --> H[Ignore later ticks]
Loading

Reviews (1) · Last reviewed commit: "Anchor PinMAME time fences to simulation..." · Reviewed by Greptile

@freezy
freezy merged commit 275098f into master Oct 20, 2026
17 checks passed
@freezy
freezy deleted the fix/urp-player-gpu-cache branch October 20, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant