Repository navigation
AgentCore Support (3/3) - Integrate AgentCore into SKILL.md, README and concepts.md - #27
Open
justinschoeff wants to merge 3 commits into
Open
justinschoeff wants to merge 3 commits into
justinschoeff wants to merge 3 commits into
Conversation
starfleeth
reviewed
Oct 7, 2026
starfleeth
left a comment
Contributor
There was a problem hiding this comment.
Could you remove the local/scripted validation narration and the promise that future manual-deployment results will be added later? Please either report completed end-to-end validation with stable evidence or leave an explicit unchecked readiness item and avoid presenting Python and TypeScript integration as fully ready until it is complete.
|
|
||
| 7. **Verify.** Start a Workflow, confirm its history progresses, and confirm the AgentCore logs show the Worker starting, processing Tasks, and draining. If it does not progress, → `references/aws-agentcore/diagnostics.md`. | ||
|
|
||
| 8. **Hand back the inventory first; offer teardown as the closing note.** Include the items in `references/aws-agentcore/setup.md` under "Resource inventory". The skill's sources do not cover AgentCore teardown commands, so ask the user how they want AgentCore resources removed before deleting any. |
Contributor
There was a problem hiding this comment.
Could you remove “the skill’s sources do not cover…” and retain the direct safety requirement? For example: “Do not delete AgentCore resources automatically. Ask the user which supported removal method they want before removing anything.”
justinschoeff
force-pushed
the
agentcore/sdk-guides
branch
from
October 26, 2026 19:20
80b5a58 to
f2f599a
Compare
justinschoeff
force-pushed
the
agentcore/skill-integration
branch
from
October 26, 2026 19:20
2ea9d62 to
74d6dee
Compare
This was referenced Oct 26, 2026
justinschoeff
force-pushed
the
agentcore/sdk-guides
branch
from
October 26, 2026 19:28
f2f599a to
7853ee9
Compare
justinschoeff
force-pushed
the
agentcore/skill-integration
branch
from
October 26, 2026 19:28
74d6dee to
734282b
Compare
justinschoeff
force-pushed
the
agentcore/sdk-guides
branch
from
October 26, 2026 19:35
7853ee9 to
a6ca3ae
Compare
justinschoeff
force-pushed
the
agentcore/skill-integration
branch
from
October 26, 2026 19:35
734282b to
e35b3f6
Compare
justinschoeff
force-pushed
the
agentcore/sdk-guides
branch
from
November 6, 2026 20:55
a6ca3ae to
7034630
Compare
justinschoeff
force-pushed
the
agentcore/skill-integration
branch
from
November 6, 2026 20:55
e35b3f6 to
cc6bbfd
Compare
justinschoeff
force-pushed
the
agentcore/sdk-guides
branch
from
November 9, 2026 16:08
7034630 to
8c5c068
Compare
Includes the follow-up fixes: Temporal-specific triggers, bounded waits, Container build for TypeScript, the AgentCore-or-Lambda justification, one Pre-release README row and the concepts provider table entry.
docs.temporal.io/cloud/namespaces#access-namespaces says that on a Namespace with both API keys and mTLS enabled, API keys cannot authenticate through the Namespace endpoint, so API-key clients must use the regional endpoint. tcld reports such a Namespace as .spec.authMethod ApiKeyOrMtls. The old text said both endpoints accept API keys, which is wrong for these Namespaces.
docs.temporal.io/cloud/namespaces#access-namespaces says that on a Namespace with both API keys and mTLS enabled, API keys cannot authenticate through the Namespace endpoint, so API-key clients must use the regional endpoint. tcld reports such a Namespace as .spec.authMethod ApiKeyOrMtls. The Lambda examples hard-code the tmprl.cloud Namespace endpoint, which fails for API-key clients on these Namespaces.
justinschoeff
force-pushed
the
agentcore/skill-integration
branch
from
November 9, 2026 16:13
cc6bbfd to
48d2fb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentCore Support (3/3). Stacked on #26 (2/3), which is stacked on #25 (1/3) →
main. The stack is rebased onto #31 and #30.This PR connects
references/aws-agentcore/to the skill's entry points, so agents send AWS users to AgentCore when it fits.What changed in this update
main(Provide clarity on Cloud Run Terraform scope, add a pool audit and rollback checks #31 Cloud Run Terraform scope / pool audit / rollback checks, Adds guidance on separate Cloud Run operator(user) and Worker API keys #30 separate Cloud Run operator and Worker API keys).SKILL.mdStep 1: kept Adds guidance on separate Cloud Run operator(user) and Worker API keys #30's Cloud Run wording (the authenticated profile is created by the operator hand-off, unless the operator reuses a working one) and added this PR's AgentCore requirement (Temporal CLI v1.8.3 or later, authenticated to the target). Adds guidance on separate Cloud Run operator(user) and Worker API keys #30/Provide clarity on Cloud Run Terraform scope, add a pool audit and rollback checks #31's other SKILL.md changes (two API-key hand-offs, the Worker-key secret, per-key inventory, the key-rotation, Terraform and pool-audit routing rows) merged cleanly and are unchanged.tcld namespace getdoes not report AgentCore Pre-release access; one Pre-release README row naming the Python and TypeScript SDKs; the AgentCore entry in the concepts provider table.Changes
SKILL.md
version:field.READYfrom the AWS API;tcld namespace getdoes not report AgentCore Pre-release access, so the skill asks the user to confirm it.README.md: AgentCore is listed in one support-table row as Supported — Pre-release (Python, TypeScript), with access notes, prerequisites, stages and repository-guide rows.
references/concepts.md: a provider-neutral pointer to
aws-agentcore/constraints.mdand an AgentCore entry in the provider table.End-to-end validation
End-to-end deploys (following the skill from Step 1)
Both runs used Temporal Cloud Namespace
quickstart-schoeff.a2dd6, AWS account 429901336738 in us-east-1, Temporal CLI 1.8.3 and the AgentCore CLI 0.28.1. In both runs, Step 1 asked the AgentCore-vs-Lambda question as a structured choice, and AgentCore was chosen. The user confirmed Pre-release access. The Step 2 approval list was approved before anything was created. The API key went into Secrets Manager without being printed.bedrock_agentcore/strands_agent(9d5c46b), with thesdk-python.mdchanges: key fromTEMPORAL_API_KEY_SECRET_ARN, required env varssdk-typescript.md(greetingWorkflow+greet)assets/temporal-cloud-serverless-worker-agentcore-role.yaml, stackschoeff-skillval-invoke(shared; second Runtime added withupdate-stack)schoeff-skillval-py, buildv3, endpointtemporal_v3schoeff-skillval-ts, buildv1, endpointtemporalschoeff-skillval-py-e2e-v3-1792784267schoeff-skillval-ts-e2e-1792773674schoeff-skillval-py:v3. 3 Activities (model, code interpreter, model): "The 30th Fibonacci number is 514229, and it is not divisible by 7."schoeff-skillval-ts:v1: "Hello, schoeff-skillval, from an AgentCore TypeScript Worker"polling schoeff-skillval-py-tq as schoeff-skillval-py/v3polling schoeff-skillval-ts-tq as schoeff-skillval-ts/v1Python took three builds, and each build got its own named endpoint, as
versioning.mdprescribes:StrandsPlugin(models=…). Strands then requiresTemporalAgent(model="bedrock"), which is a Workflow code change.The model swap is agent code, which this skill links to rather than covers. Everything the run created was torn down afterwards.
Fixes made from the runs
Folded into #25, #26 and this PR (each PR is now one squashed commit):
main.tsalone and ships nonode_modules, soagentcore deployfailed at synth. The packager can't load@temporalio/worker's native swc and core-bridge modules, and the CLI can't take a prebuilt zip.ca-certificates, because the Worker failed withTransportError … NativeCertsNotFoundonnode:22-slim. It must also run compileddist/main.js, because the CLI template'snpx tsx main.tsbreaksworkflowsPath: './workflows.js'./aws/bedrock-agentcore/runtimes/<RUNTIME_ID>-<ENDPOINT>).agentcore logs --runtimereturned nothing.READYfromaws bedrock-agentcore-control get-agent-runtime-endpoint.agentcore statusonly reportsdeployed.aws-targets.json, whichagentcore createleaves as[].additionalPoliciesrelative tocodeLocation, not the project root. The TypeScript synth failed withENOENT.agentcore deployturned on.iam.mdshows how to add a Runtime to an existing invocation stack (escaped comma inAgentRuntimeARNs).sdk-python.mdnotes that the sample needs Bedrock model access./aws/bedrock-agentcore/runtimes/<RUNTIME_ID>-<ENDPOINT>group per endpoint, includingDEFAULT. A Container build also left its CodeBuild and build-trigger Lambda log groups.