Skip to content

AgentCore Support (1/3) - Add AgentCore provider references and role templates - #25

Open
justinschoeff wants to merge 1 commit into
mainfrom
agentcore/references
Open

justinschoeff wants to merge 1 commit into
mainfrom
agentcore/references

Conversation

@justinschoeff

@justinschoeff justinschoeff commented Oct 7, 2026 •

Copy link
Copy Markdown

AgentCore Support (1/3). Based on main, rebased onto #31 and #30. (2/3) is #26, and (3/3) is #27.

This PR adds Amazon Bedrock AgentCore Runtime (aws-agentcore) as a Serverless Worker provider. It follows the references/aws-lambda/ and references/gcp-cloud-run/ layout. It changes files under references/aws-agentcore/ and assets/, plus the AgentCore entries in the shared references/wci.md inspection flow. The SDK guides come in #26, and SKILL.md, README and concepts.md are integrated in #27.

What changed in this update

What's added

  • references/aws-agentcore/:
    • constraints.md: the 8 h microVM lifetime; how the Worker idle policy and the AgentCore lifecycle settings stop the Worker; process-local reuse and no-sync autoscaling; one named endpoint per WDV.
    • setup.md: the AgentCore CLI path, with no local Docker. Python uses CodeZip, and TypeScript uses the Container build, which the CLI builds in AWS CodeBuild. It also covers:
      • the project-name prefix and aws-targets.json;
      • the Secrets Manager API-key hand-off, with the policy file in codeLocation;
      • named endpoints, and the endpoint READY check through get-agent-runtime-endpoint;
      • Worker logs from the named endpoint's log group;
      • a created/reused inventory that includes the CDK stack, Container resources, log groups and Transaction Search;
      • Teardown, including the log groups AgentCore leaves behind.
    • iam.md: the operator, the Runtime execution role and the invocation role, for Cloud and self-hosted. It covers the API-key lifecycle and adding a Runtime to an existing invocation stack.
    • versioning.md: how WDVs map to Runtime versions and named endpoints, the DEFAULT hazard, and rollout and rollback.
    • diagnostics.md: documented gotchas plus the shared references/wci.md flow.
    • observability.md
    • self-hosted.md: a full guide for v1.32.0+.
  • assets/temporal-cloud-serverless-worker-agentcore-role.yaml: byte-identical to the S3 template (https://temporal-server-scaled-workers-config.s3.us-west-2.amazonaws.com/cloudformation/temporal-worker-role-agentcore.yaml).
  • assets/temporal-self-hosted-serverless-worker-agentcore-role.yaml: from the docs' static/files/ copy (trusts TemporalIamRoleArn).

The durable-agent guide is linked, not reproduced. Following #29, the files have no <!-- --> source tags.

Validation

  • Every relative link and anchor in the files this PR changes resolves (scripted check).
  • No <!-- comments in references/aws-agentcore/ or references/concepts.md; no version: field in SKILL.md.
  • skills-ref validate (agentskills 0.1.1) reports only disable-model-invocation as an unexpected frontmatter field. main has the same error, so this PR doesn't introduce it. With that field removed, the skill validates.
  • Python and TypeScript end-to-end deploys: see AgentCore Support (3/3) - Integrate AgentCore into SKILL.md, README and concepts.md #27.

@justinschoeff
justinschoeff requested a review from a team as a code owner October 7, 2026 19:02

@starfleeth starfleeth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you trim the authoring and local-environment narration from this description? In particular, please remove the /tmp/... paths, raw local validation transcript, “cmp passes,” “None comes from a test run,” and the discussion of which branch should fix the existing validator failure. A concise result-oriented section would be more durable: canonical template provenance, link/citation checks passed, and one known base-branch validator issue linked to its tracking item.

Comment thread references/aws-agentcore/diagnostics.md Resolved
Comment thread references/aws-agentcore/iam.md Resolved
Comment thread references/aws-agentcore/setup.md Resolved
Comment thread references/aws-agentcore/constraints.md Resolved
An error occurred while trying to automatically change base from codex/provider-constraints-layout to cloud-run-skill-support October 7, 2026 22:40
@justinschoeff
justinschoeff changed the base branch from codex/provider-constraints-layout to main October 26, 2026 19:20
Includes the CONTRIBUTING and PR-review fixes found by the end-to-end
runs: bounded waits, warm and scale-from-zero checks, endpoint state
and logs from the AWS API, full deploy inventory and teardown,
Region-scoped commands, the regional endpoint on dual-auth Namespaces,
and AgentCore entries in the shared wci.md diagnosis flow.

Evidence (Namespace quickstart-schoeff.a2dd6, us-east-1, 2026-10-27):
Python schoeff-skillval2-py: skillval2-py-s1-warm-1793124031,
skillval2-py-s2-cold-1793124113, skillval2-py-s3-v2-1793124259,
skillval2-py-s3-rollback-1793124278, skillval2-py-s4-bad-1793124600,
skillval2-py-s4-restore-1793124652. TypeScript schoeff-skillval2-ts:
ts-s1-warm-1, ts-s2-cold-1, ts-s3-v2-1, ts-s3-rollback-1, ts-s4-bad-1,
ts-s4-restore-1. All completed. v2 on endpoint temporal_v2 (Runtime
version 2), rollback by setting v1 current with no redeploy.
Checked with Temporal CLI 1.8.3, agentcore CLI 0.28.1, aws-cli 2.35.15
(bedrock-agentcore-control 2023-06-05, secretsmanager 2017-10-17).
@justinschoeff justinschoeff changed the title AgentCore Support (1/3) - Add AgentCore provider references AgentCore Support (1/3) - Add AgentCore provider references and role templates Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants