Repository navigation
AgentCore Support (1/3) - Add AgentCore provider references and role templates - #25
Open
justinschoeff wants to merge 1 commit into
Open
justinschoeff wants to merge 1 commit into
justinschoeff wants to merge 1 commit into
Conversation
starfleeth
reviewed
Oct 7, 2026
starfleeth
left a comment
Contributor
There was a problem hiding this comment.
Could you trim the authoring and local-environment narration from this description? In particular, please remove the /tmp/... paths, raw local validation transcript, “cmp passes,” “None comes from a test run,” and the discussion of which branch should fix the existing validator failure. A concise result-oriented section would be more durable: canonical template provenance, link/citation checks passed, and one known base-branch validator issue linked to its tracking item.
An error occurred while trying to automatically change base from
codex/provider-constraints-layout
to
cloud-run-skill-support
October 7, 2026 22:40
justinschoeff
force-pushed
the
agentcore/references
branch
from
October 26, 2026 19:20
1feb04e to
a270af9
Compare
justinschoeff
changed the base branch from
codex/provider-constraints-layout
to
main
October 26, 2026 19:20
This was referenced Oct 26, 2026
Includes the CONTRIBUTING and PR-review fixes found by the end-to-end runs: bounded waits, warm and scale-from-zero checks, endpoint state and logs from the AWS API, full deploy inventory and teardown, Region-scoped commands, the regional endpoint on dual-auth Namespaces, and AgentCore entries in the shared wci.md diagnosis flow. Evidence (Namespace quickstart-schoeff.a2dd6, us-east-1, 2026-10-27): Python schoeff-skillval2-py: skillval2-py-s1-warm-1793124031, skillval2-py-s2-cold-1793124113, skillval2-py-s3-v2-1793124259, skillval2-py-s3-rollback-1793124278, skillval2-py-s4-bad-1793124600, skillval2-py-s4-restore-1793124652. TypeScript schoeff-skillval2-ts: ts-s1-warm-1, ts-s2-cold-1, ts-s3-v2-1, ts-s3-rollback-1, ts-s4-bad-1, ts-s4-restore-1. All completed. v2 on endpoint temporal_v2 (Runtime version 2), rollback by setting v1 current with no redeploy. Checked with Temporal CLI 1.8.3, agentcore CLI 0.28.1, aws-cli 2.35.15 (bedrock-agentcore-control 2023-06-05, secretsmanager 2017-10-17).
justinschoeff
force-pushed
the
agentcore/references
branch
from
November 6, 2026 20:55
6d124ee to
6e0eb55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentCore Support (1/3). Based on
main, rebased onto #31 and #30. (2/3) is #26, and (3/3) is #27.This PR adds Amazon Bedrock AgentCore Runtime (
aws-agentcore) as a Serverless Worker provider. It follows thereferences/aws-lambda/andreferences/gcp-cloud-run/layout. It changes files underreferences/aws-agentcore/andassets/, plus the AgentCore entries in the sharedreferences/wci.mdinspection flow. The SDK guides come in #26, and SKILL.md, README and concepts.md are integrated in #27.What changed in this update
main(Provide clarity on Cloud Run Terraform scope, add a pool audit and rollback checks #31 Cloud Run Terraform scope / pool audit / rollback checks, Adds guidance on separate Cloud Run operator(user) and Worker API keys #30 separate Cloud Run operator and Worker API keys). The two Teardown log-group commits that were previously separate on this branch are now folded in.references/wci.md: kept Adds guidance on separate Cloud Run operator(user) and Worker API keys #30's Cloud Run wording (the operator's profile fromgcp-cloud-run/setup.md) and this PR's AgentCore addition (use the connection from the provider'ssetup.md).setup.mdsays whereTEMPORAL_ADDRESScomes from;references/wci.md(continue-as-new run lookup, theInvokeWorker/PullStatssignature).What's added
references/aws-agentcore/:constraints.md: the 8 h microVM lifetime; how the Worker idle policy and the AgentCore lifecycle settings stop the Worker; process-local reuse and no-sync autoscaling; one named endpoint per WDV.setup.md: the AgentCore CLI path, with no local Docker. Python uses CodeZip, and TypeScript uses the Container build, which the CLI builds in AWS CodeBuild. It also covers:aws-targets.json;codeLocation;READYcheck throughget-agent-runtime-endpoint;iam.md: the operator, the Runtime execution role and the invocation role, for Cloud and self-hosted. It covers the API-key lifecycle and adding a Runtime to an existing invocation stack.versioning.md: how WDVs map to Runtime versions and named endpoints, theDEFAULThazard, and rollout and rollback.diagnostics.md: documented gotchas plus the sharedreferences/wci.mdflow.observability.mdself-hosted.md: a full guide for v1.32.0+.assets/temporal-cloud-serverless-worker-agentcore-role.yaml: byte-identical to the S3 template (https://temporal-server-scaled-workers-config.s3.us-west-2.amazonaws.com/cloudformation/temporal-worker-role-agentcore.yaml).assets/temporal-self-hosted-serverless-worker-agentcore-role.yaml: from the docs'static/files/copy (trustsTemporalIamRoleArn).The durable-agent guide is linked, not reproduced. Following #29, the files have no
<!-- -->source tags.Validation
<!--comments inreferences/aws-agentcore/orreferences/concepts.md; noversion:field in SKILL.md.skills-ref validate(agentskills 0.1.1) reports onlydisable-model-invocationas an unexpected frontmatter field.mainhas the same error, so this PR doesn't introduce it. With that field removed, the skill validates.