Repository navigation
AgentCore Support (2/3) - Add Python and TypeScript SDK guides - #26
Open
justinschoeff wants to merge 170 commits into
Open
justinschoeff wants to merge 170 commits into
justinschoeff wants to merge 170 commits into
Conversation
…io/skill-temporal-serverless into cloud-run-sdk-guides
…-temporal-serverless into cloud-run-sdk-guides
…ill-temporal-serverless into cloud-run-skill-support
…-temporal-serverless into cloud-run-sdk-guides
…-temporal-serverless into cloud-run-sdk-guides
…ill-temporal-serverless into cloud-run-skill-support
The provider is now settled in step 1 by deriving it from the Namespace or asking, and the agent states it to the user. Move the tcld sign-in rule ahead of the Namespace discovery calls it governs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Give the registration-race check a stopping point that leads to the provisioning diagnosis, say to wait a few minutes before the single IAM-propagation retry, and take only the Collector configuration from the samples-go Cloud Run sample, whose Worker Pool manifest is unversioned. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The OpenTelemetry path deploys a multi-container manifest with gcloud run worker-pools replace, so the variable belongs in the Worker container's env rather than a deploy flag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With two providers and the Cloud Run API-key requirement, a Namespace can be ineligible because its cloud is unsupported, because it accepts only mTLS, or because it does not match the requested provider. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e pool Step 8 now starts whatever Workflow type and input the deployed Worker registers, with the SDK guide samples as defaults, and notes that interrupting workflow execute leaves the Workflow running. The pool log queries and the UpdateWorkerPool audit query are scoped to the pool's name and region; both labels are present on container output and on the resize audit entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A healthy Java Worker can complete Workflows and Activities without per-task SDK log lines. Confirm execution from the Workflow history, and use SLF4J's no-provider warning, not the stdout startup line, to tell whether logging is bound. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ask the user to run tcld login in their own terminal without naming a client. Offer every eligible Namespace as an option when they fit in a structured question; otherwise print the complete numbered list and let the user reply with a number, never offering only a subset. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…dex/provider-constraints-layout
Temporal assumes an IAM role to get and invoke a named AgentCore Runtime endpoint. Ship both variants next to the Lambda templates so the references can point at local, reviewable copies: the Cloud template byte-identical to Temporal's S3 copy, and the self-hosted template from the docs, which trusts a TemporalIamRoleArn principal.
Document AgentCore Runtime's execution model for Serverless Workers: the 8-hour microVM lifetime, the two independent stop controls (Worker idle policy vs AgentCore lifecycle settings), and why each Worker Deployment Version must map to its own named endpoint rather than the moving DEFAULT endpoint. Every claim cites its source.
AgentCore has no Temporal troubleshooting page, so diagnostics is limited to documented gotchas (endpoint vs Runtime ARN, missing ARN wildcard, name mismatches, DEFAULT drift, sessions stuck HealthyBusy) plus the shared WCI inspection flow. Waits are gated on observable registration state, not test-run durations.
Cover the AgentCore CLI + CodeZip deploy path (no Docker or ECR), the three identities involved (operator, Runtime execution role, Temporal invocation role) and a complete self-hosted Temporal Service guide, since AgentCore supports self-hosting from v1.32.0. Namespace selection lists every AWS-hosted Namespace and confirms Pre-release access before deploying.
Give the skill the language-specific half of setup.md Step 2 for Python: bedrock-agentcore's BedrockAgentCoreApp serves /invocations and /ping, the handler starts a versioned Worker as an AgentCore async task, and an Activity-tracking idle policy drains it so the session does not stay HealthyBusy until maxLifetime. Code and settings follow the samples-python strands_agent sample, which the guide links to.
starfleeth
reviewed
Oct 7, 2026
starfleeth
left a comment
Contributor
There was a problem hiding this comment.
Please replace the narrative about unsourced TypeScript details and a future end-to-end run with an explicit support status and known limitations. The validation section can also report outcomes directly without git diff commands or the history of which branch introduced the validator error. If the base error still matters, link its tracking issue.
| app.run() | ||
| ``` | ||
|
|
||
| The sample falls back to defaults when these variables are unset; this version reads `os.environ[...]` so a missing setting fails at startup instead of polling the wrong Namespace or Task Queue. If an Activity is a synchronous function, pass an `activity_executor` such as a `ThreadPoolExecutor` to `Worker()`, as the sample does for `execute_code`. <!-- samples-python/bedrock_agentcore/strands_agent/agentcore_worker.py:48-50; docs/develop/python/workers/serverless-workers/agentcore.mdx:95-102 --> |
Contributor
There was a problem hiding this comment.
“This version reads…” narrates how this example was authored relative to the upstream sample. Could you state the behavior directly instead? For example: “Read these values with os.environ[...] so a missing setting fails at startup instead of silently selecting the wrong Namespace or Task Queue.”
justinschoeff
force-pushed
the
agentcore/sdk-guides
branch
from
October 26, 2026 19:20
80b5a58 to
f2f599a
Compare
justinschoeff
force-pushed
the
agentcore/references
branch
from
October 26, 2026 19:20
1feb04e to
a270af9
Compare
justinschoeff
force-pushed
the
agentcore/sdk-guides
branch
2 times, most recently
from
October 26, 2026 19:35
7853ee9 to
a6ca3ae
Compare
justinschoeff
force-pushed
the
agentcore/sdk-guides
branch
from
November 6, 2026 20:55
a6ca3ae to
7034630
Compare
justinschoeff
force-pushed
the
agentcore/references
branch
from
November 6, 2026 20:55
6d124ee to
6e0eb55
Compare
Mirror the Python guide's structure for TypeScript using the AWS bedrock-agentcore npm package and the standard Temporal TypeScript SDK. Temporal publishes no TypeScript AgentCore code or sample, so the guide marks every unpublished detail (esbuild and workflowsPath, core-bridge arm64 packaging, SIGTERM on compute end) as not covered by the docs so the consuming agent verifies it instead of asserting it.
justinschoeff
force-pushed
the
agentcore/sdk-guides
branch
from
November 9, 2026 16:08
7034630 to
8c5c068
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentCore Support (2/3). Stacked on #25 (
agentcore/references), which is based onmainafter #31 and #30. (3/3) is #27. This PR adds the per-SDK entry-point guides thatsetup.mdStep 2 points to.What changed in this update
main. No conflicts in this PR's files.Changes
references/aws-agentcore/sdk-python.md: built on the AWSbedrock-agentcorepackage (BedrockAgentCoreAppserves/invocationsand/ping). It covers:setup.md), Heartbeats and log signatures.references/aws-agentcore/sdk-typescript.md: the same plan, built on thebedrock-agentcorenpm package. It uses the CLI's Container build, because the Node CodeZip packager (esbuild onmain.ts, nonode_modules) can't bundle@temporalio/worker. Its Dockerfile is based on the CLI's own template:tscand runsdist/main.js, soworkflowsPathresolves.ca-certificates, which fixes theNativeCertsNotFoundTLS failure.Validation
skills-ref validateresult is unchanged frommain: only the pre-existingdisable-model-invocationfield is flagged.