Repository navigation
fix(pmdg): read FSUIPC light switches as bytes - #30
Merged
Merged
Conversation
PMDG SDK switch fields are one byte each, packed back to back. The client reads FeatureType.Int as four bytes, so each light picked up its neighbours and `== 1` failed as soon as any of them was on: landing swallowed the other two landing lights and the beacon, beacon swallowed nav/logo/wing, taxi swallowed strobe. Taxi only "worked" because strobes are off while taxiing. 777 nav was also 0x650B, the 747's address; on the 777 that byte is the chronograph selector. The 777 nav switch is 0x6489. Landing lights stay Int: the 777 has three switch bytes and the 747 four, so one Int read covers them and the method masks to "any on".
This was referenced Nov 16, 2026
nabeelio
added a commit
that referenced
this pull request
Nov 16, 2026
## Summary Same model `main` got in #28: branch pushes publish a preview zip, only a release writes the file clients download. ```diff push to releases/2.0 artifacts publish - scripts/stable.zip # every 2.x client, on every merge + scripts/releases-2.0.zip # preview; point a Replane 2.x channel at it purge acars.cdn.vmslabs.net/* workflow_dispatch (bump: patch|minor|major) release bump src/package.json, tag vX.Y.Z, push + scripts/stable.zip # the only writer now purge GitHub release ``` `src/package.json` goes `1.0.1` → `2.0.0`, so the first dispatch with `patch` tags `v2.0.1`. ## Evidence - **Before:** merging #22 on 11-09 pushed straight to `scripts/stable.zip`, which is how the A220 fix shipped unannounced. **After:** YAML parses (`js-yaml`). Tag pushes made by the release job use `GITHUB_TOKEN`, so they do not retrigger the push workflow; `stable.zip` is written once per release. Not exercised; first real run is the PMDG release after #30. ## Merge Danger **Door:** two-way Revert restores publish-on-push. **Blast Radius:** release-process Merging #30 after this no longer ships the PMDG fix by itself; you must run the Build workflow on `releases/2.0` with a bump. Nothing changes for clients until then.
nabeelio
added a commit
that referenced
this pull request
Nov 16, 2026
## Summary Port of #30 to the 3.x JSON configs. PMDG SDK switch fields are one byte each, packed back to back; `valueType: int` reads four bytes, so each light swallowed its neighbours and `equal 1` failed whenever any of them was on. ```diff pmdg-777-fsuipc.json - BeaconLights 0x6488 int == 1 - LandingLights 0x6485 int == 1 - NavigationLights 0x650B int == 1 # 747 address; 777 chronograph - StrobeLights 0x648F int == 1 - TaxiLights 0x648E int == 1 + BeaconLights 0x6488 byte == 1 + LandingLights any(0x6485, 0x6486, 0x6487 byte == 1) # L / R / nose + NavigationLights 0x6489 byte == 1 + StrobeLights 0x648F byte == 1 + TaxiLights 0x648E byte == 1 pmdg-747-fsuipc.json - beacon/nav/strobe/taxi int - LandingLights 0x6506 int == 1 + beacon/nav/strobe/taxi byte (same values) + LandingLights any(0x6506..0x6509 byte == 1) ``` The 2.x TS configs could mask one int read; the JSON engine has no mask operator, so landing lights become an `any` over the individual switch bytes. ## Evidence - **Before:** P3D + PMDG 777 on 2.2: taxi detected, landing/strobes never. Same offsets and widths here. **After:** `npm run build` clean; `artifacts/aircraft.json` carries 3 landing conditions + nav `0x6489` for the 777, 4 landing conditions for the 747. Not flown. ## Merge Danger **Door:** two-way Merge publishes `v8/main.zip` and the `-main` aliases only; released 3.x clients see it after the next release dispatch. **Blast Radius:** PMDG-FSUIPC P3D/FSX pilots on the PMDG 777 or 747 via FSUIPC.
nabeelio
added a commit
that referenced
this pull request
Nov 16, 2026
## Summary The `2.1.0` release made in the GitHub UI published nothing: the workflow only fired on `v*` tags and only wrote `stable.zip` for `refs/tags/v*`. One release path now, the UI tag. ```diff on.push.tags 'v*' + '[0-9]*' # 2.1.0, what the UI release made publish (tag) - if ref == refs/tags/v* → scripts/stable.zip + if ref == refs/tags/* → scripts/stable.zip purge + attach stable.zip to the GitHub release -release (workflow_dispatch, bump: patch|minor|major) - npm version → commit → tag v<ver> → upload → GH release ``` `artifacts` no longer carries the `workflow_dispatch` guard. ## Evidence - **Before:** release `2.1.0` at 19:30 → zero workflow runs. `scripts/stable.zip` on the CDN is from the #30 merge push at 19:02, not the release. **After:** YAML parses. Not exercised; the first run is the next UI release on `releases/2.0`. ## Merge Danger **Door:** two-way **Blast Radius:** release-process Removes the Run-workflow button flow. A UI release on this branch now writes `scripts/stable.zip` for every 2.x client.
nabeelio
added a commit
that referenced
this pull request
Nov 16, 2026
## Summary Follow-up to #30. The PMDG 737 FSUIPC config read only the left fixed landing switch (0x64F6), so flights flown on the retractable lights, or with only the right fixed light on, logged landing lights off. Logo (0x64FF) and wing (0x6502) switches exist in the NGX offset map but were disabled. - Landing: one 4-byte read at 0x64F4 covers `LTS_LandingLtRetractableSw[2]` (on when 2) and `LTS_LandingLtFixedSw[2]` (boolean); any of the four lit counts as on. - Logo and wing: 1-byte reads, on when 1. ## Evidence Addresses and widths from `Offset Mapping for PMDG 737NGX.pdf` (bottom overhead block: 64F4 retractable[2], 64F6 fixed[2], 64FF logo, 6500 position, 6501 anticollision, 6502 wing). `npm run build` passes; the compiled `dist/aircraft/PMDG_737_FSUIPC.js` carries the new offsets. ## Merge Danger Low. Only the 737 FSUIPC config changes. Pilots who previously got landing lights "off" with the retractable lights on will now get "on"; no other feature changes. Ships to 2.x clients on the next release tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PMDG SDK switch fields are one byte each, packed back to back. The 2.x client reads
FeatureType.Intas four bytes, so each light picked up its neighbours and== 1failed whenever any neighbour was on.Taxi only "worked" because strobes are off while taxiing. No client change:
release/2.2already mapsByteto a one-byte offset read.Evidence
scripts/stable.zipand a rebuild of the Aug 10 tree differ only inSynapticA220.js, so the config publish on 11-09 did not change this; the read width has been 4 bytes since 2.2.65.After:
npm run buildclean;dist/aircraft/PMDG_777_FSUIPC.jsandPMDG_747_FSUIPC.jscarry theBytetypes,0x6489, and the masked landing checks. Not flown; needs a PMDG 777 / 747 P3D pass.Merge Danger
Door: two-way
Merge publishes
scripts/stable.zipand purges the CDN; a revert republishes the previous configs the same way.Blast Radius: PMDG-FSUIPC
Only pilots on P3D/FSX with the PMDG 777 or 747 via FSUIPC. The 747 beacon/nav
== 0 || == 2checks are untouched.