Repository navigation
fix(pmdg): read all 737 landing switches, add logo and wing - #35
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #30. The PMDG 737 FSUIPC config read only the left fixed landing switch (0x64F6), so flights flown on the retractable lights, or with only the right fixed light on, logged landing lights off. Logo (0x64FF) and wing (0x6502) switches exist in the NGX offset map but were disabled.
LTS_LandingLtRetractableSw[2](on when 2) andLTS_LandingLtFixedSw[2](boolean); any of the four lit counts as on.Evidence
Addresses and widths from
Offset Mapping for PMDG 737NGX.pdf(bottom overhead block: 64F4 retractable[2], 64F6 fixed[2], 64FF logo, 6500 position, 6501 anticollision, 6502 wing).npm run buildpasses; the compileddist/aircraft/PMDG_737_FSUIPC.jscarries the new offsets.Merge Danger
Low. Only the 737 FSUIPC config changes. Pilots who previously got landing lights "off" with the retractable lights on will now get "on"; no other feature changes. Ships to 2.x clients on the next release tag.