Skip to content

fix(pmdg): read FSUIPC light switches as bytes - #32

Merged
nabeelio merged 1 commit into
mainfrom
fix/pmdg-fsuipc-light-offsets-main
Nov 16, 2026
Merged

nabeelio merged 1 commit into
mainfrom
fix/pmdg-fsuipc-light-offsets-main

Conversation

@nabeelio

Copy link
Copy Markdown
Member

Summary

Port of #30 to the 3.x JSON configs. PMDG SDK switch fields are one byte each, packed back to back; valueType: int reads four bytes, so each light swallowed its neighbours and equal 1 failed whenever any of them was on.

 pmdg-777-fsuipc.json
-  BeaconLights   0x6488 int == 1
-  LandingLights  0x6485 int == 1
-  NavigationLights 0x650B int == 1     # 747 address; 777 chronograph
-  StrobeLights   0x648F int == 1
-  TaxiLights     0x648E int == 1
+  BeaconLights   0x6488 byte == 1
+  LandingLights  any(0x6485, 0x6486, 0x6487 byte == 1)   # L / R / nose
+  NavigationLights 0x6489 byte == 1
+  StrobeLights   0x648F byte == 1
+  TaxiLights     0x648E byte == 1

 pmdg-747-fsuipc.json
-  beacon/nav/strobe/taxi  int
-  LandingLights  0x6506 int == 1
+  beacon/nav/strobe/taxi  byte (same values)
+  LandingLights  any(0x6506..0x6509 byte == 1)

The 2.x TS configs could mask one int read; the JSON engine has no mask operator, so landing lights become an any over the individual switch bytes.

Evidence

  • Before: P3D + PMDG 777 on 2.2: taxi detected, landing/strobes never. Same offsets and widths here.
    After: npm run build clean; artifacts/aircraft.json carries 3 landing conditions + nav 0x6489 for the 777, 4 landing conditions for the 747. Not flown.

Merge Danger

Door: two-way

Merge publishes v8/main.zip and the -main aliases only; released 3.x clients see it after the next release dispatch.

Blast Radius: PMDG-FSUIPC

P3D/FSX pilots on the PMDG 777 or 747 via FSUIPC.

Same fix as releases/2.0 (#30). PMDG SDK switch fields are one byte
each, packed back to back; an int read is four bytes, so each light
picked up its neighbours and `equal 1` failed as soon as any of them was
on. Landing lights are three (777) or four (747) adjacent switch bytes,
so they become an "any" over the individual bytes.

777 nav was 0x650B, the 747's address; on the 777 that is the
chronograph selector. The 777 nav switch is 0x6489.
@nabeelio
nabeelio merged commit 51be8b4 into main Nov 16, 2026
4 checks passed
@nabeelio
nabeelio deleted the fix/pmdg-fsuipc-light-offsets-main branch November 16, 2026 19:10
nabeelio added a commit that referenced this pull request Nov 16, 2026
## Summary

The `3.0.0-beta.1` release made in the GitHub UI published nothing: the
workflow only fired on `v*` tags, so `v8/stable.zip` and
`aircraft-latest.json` are still 11-12 / 11-13 and 3.x clients do not
have #32. One release path now, the UI tag.

```diff
 on.push.tags
   'v*'
+  '[0-9]*'                               # 3.0.0-beta.1, what the UI release made

 publish (tag)
-  if ref == refs/tags/v*  → v8/stable.zip, VERSION=${ref#refs/tags/v}
+  if ref == refs/tags/*   → v8/stable.zip, VERSION=${GITHUB_REF_NAME#v}
   aircraft-${VERSION}.json + aircraft-latest.json
   settings-${VERSION}.json + settings-latest.json
   purge
+  attach stable.zip, aircraft.json, settings.json to the GitHub release

-release (workflow_dispatch, bump: patch|minor|major)
-  npm version → commit → tag v<ver> → upload → GH release
```

`3.0.0-beta.1` → `aircraft-3.0.0-beta.1.json`; `v1.0.1` →
`aircraft-1.0.1.json`. `artifacts` no longer carries the
`workflow_dispatch` guard.

## Evidence

- **Before:** release `3.0.0-beta.1` at 19:31 → zero workflow runs.
`configs/aircraft-latest.json` Last-Modified 2026-11-13.
**After:** YAML parses. Not exercised; to ship #32 to 3.x, re-create the
`3.0.0-beta.1` tag (or cut `3.0.0-beta.2`) after this merges.

## Merge Danger

**Door:** two-way

**Blast Radius:** release-process

Removes the Run-workflow button flow. A UI release on `main` now moves
`-latest` for every released 3.x client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant