Repository navigation
fix(pmdg): read FSUIPC light switches as bytes - #32
Merged
Merged
Conversation
Same fix as releases/2.0 (#30). PMDG SDK switch fields are one byte each, packed back to back; an int read is four bytes, so each light picked up its neighbours and `equal 1` failed as soon as any of them was on. Landing lights are three (777) or four (747) adjacent switch bytes, so they become an "any" over the individual bytes. 777 nav was 0x650B, the 747's address; on the 777 that is the chronograph selector. The 777 nav switch is 0x6489.
nabeelio
added a commit
that referenced
this pull request
Nov 16, 2026
## Summary The `3.0.0-beta.1` release made in the GitHub UI published nothing: the workflow only fired on `v*` tags, so `v8/stable.zip` and `aircraft-latest.json` are still 11-12 / 11-13 and 3.x clients do not have #32. One release path now, the UI tag. ```diff on.push.tags 'v*' + '[0-9]*' # 3.0.0-beta.1, what the UI release made publish (tag) - if ref == refs/tags/v* → v8/stable.zip, VERSION=${ref#refs/tags/v} + if ref == refs/tags/* → v8/stable.zip, VERSION=${GITHUB_REF_NAME#v} aircraft-${VERSION}.json + aircraft-latest.json settings-${VERSION}.json + settings-latest.json purge + attach stable.zip, aircraft.json, settings.json to the GitHub release -release (workflow_dispatch, bump: patch|minor|major) - npm version → commit → tag v<ver> → upload → GH release ``` `3.0.0-beta.1` → `aircraft-3.0.0-beta.1.json`; `v1.0.1` → `aircraft-1.0.1.json`. `artifacts` no longer carries the `workflow_dispatch` guard. ## Evidence - **Before:** release `3.0.0-beta.1` at 19:31 → zero workflow runs. `configs/aircraft-latest.json` Last-Modified 2026-11-13. **After:** YAML parses. Not exercised; to ship #32 to 3.x, re-create the `3.0.0-beta.1` tag (or cut `3.0.0-beta.2`) after this merges. ## Merge Danger **Door:** two-way **Blast Radius:** release-process Removes the Run-workflow button flow. A UI release on `main` now moves `-latest` for every released 3.x client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port of #30 to the 3.x JSON configs. PMDG SDK switch fields are one byte each, packed back to back;
valueType: intreads four bytes, so each light swallowed its neighbours andequal 1failed whenever any of them was on.The 2.x TS configs could mask one int read; the JSON engine has no mask operator, so landing lights become an
anyover the individual switch bytes.Evidence
After:
npm run buildclean;artifacts/aircraft.jsoncarries 3 landing conditions + nav0x6489for the 777, 4 landing conditions for the 747. Not flown.Merge Danger
Door: two-way
Merge publishes
v8/main.zipand the-mainaliases only; released 3.x clients see it after the next release dispatch.Blast Radius: PMDG-FSUIPC
P3D/FSX pilots on the PMDG 777 or 747 via FSUIPC.