Skip to content

Refactor server code to the reviewed style - #13

Merged
Eoic merged 1 commit into
developmentfrom
feature/code-style-refactor
Oct 9, 2026
Merged

Eoic merged 1 commit into
developmentfrom
feature/code-style-refactor

Conversation

@Eoic

@Eoic Eoic commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Summary

Apply the maintainer's reviewed coding style across server code and tests. Keep consecutive single-line statements together, separate blocks and multiline statements, and use trailing commas for deliberate multiline argument layouts. Replace the nested goal-progress conditional with explicit branches and document the conventions in AGENTS.md.

Validation

  • tools/papyrus check server: Ruff lint, Ruff formatting, and mypy passed.
  • tools/papyrus test server: 374 passed; two external auth smoke tests deselected by the workspace CLI.
  • git diff --check: passed.

The full suite ran before the final whitespace correction. Static checks were repeated afterward. Python AST comparison verified that formatting changes preserved the syntax tree; the only structural rewrite is the equivalent goal-progress conditional.

Compatibility

No intended behavior, REST contract, ownership, schema, dependency, or version changes. Historical migration sources remain unchanged.

Coordinated PRs: client #43 and workspace #14. Merge the component PRs before integrating the workspace pointers.

Copilot AI balanced review requested due to automatic review settings October 9, 2026 23:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T23:30:03.545266Z 9b883c9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Eoic
Eoic merged commit 7e45e6b into development Oct 9, 2026
1 check passed
@Eoic
Eoic deleted the feature/code-style-refactor branch October 9, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants