Skip to content

Document reviewed coding style and pin client/server refactors - #14

Merged
Eoic merged 1 commit into
developmentfrom
feature/code-style-refactor
Oct 9, 2026
Merged

Eoic merged 1 commit into
developmentfrom
feature/code-style-refactor

Conversation

@Eoic

@Eoic Eoic commented Oct 9, 2026

Copy link
Copy Markdown
Member

Summary

Record the maintainer's reviewed client/server coding conventions in CODING_STYLE.md and link them from the workspace agent instructions. The spacing rule keeps consecutive single-line statements together and separates blocks and multiline statements.

Update the client/server submodule pointers to their coordinated style refactors:

The temporary code-style-review directory was deleted locally as requested; it had never been committed. Existing reader, docs, and website pointer changes are excluded.

Validation

  • tools/papyrus check references: passed.
  • Client formatter/analyzer/bootstrap checks, 1,604 client tests, and web build passed; 19 tests skipped.
  • Server Ruff/mypy checks and 374 tests passed; two external auth smoke tests deselected.
  • Final spacing corrections preserved Dart tokens and Python syntax trees; static checks were repeated afterward.
  • Staged diff whitespace checks passed in all three repositories.

Merge coordination

Merge the client and server PRs first. If rebasing changes either component commit ID, refresh the corresponding workspace pointer before merging this PR.

No dependency, version, storage, or intended behavior changes.

Copilot AI balanced review requested due to automatic review settings October 9, 2026 23:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T23:30:28.341719Z 52d3ef6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Eoic
Eoic merged commit 2a9883a into development Oct 9, 2026
4 checks passed
@Eoic
Eoic deleted the feature/code-style-refactor branch October 9, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants