Repository navigation
Refactor client code to the reviewed style - #43
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 9, 2026
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply the maintainer's reviewed coding style across client code and tests: clearer local and callback names, braces around guards and loops, explicit branches in place of nested ternaries, focused metadata URL and OPDS validation helpers, and removal of redundant comments.
Keep consecutive single-line statements together and put blank lines around blocks and multiline statements. Preserve deliberate trailing commas with the existing 120-character formatter width. Document these conventions in
AGENTS.md.Testing
From the workspace root:
tools/papyrus check client: formatter, analyzer, and all four web bootstrap tests passed.tools/papyrus test client: 1,604 passed, 19 skipped.client/app,../../tools/flutter build web --dart-define-from-file=.dart_defines: passed.git diff --check: passed.The full suite and web build ran before the final whitespace correction. Static checks were repeated afterward; token comparison verified that the spacing correction changed no Dart tokens.
UI evidence
Not applicable. No intentional visual changes.
Compatibility and migration
No intended behavior, API, dependency, version, or storage changes. Reviewed samples were used as style references rather than copied directly because some contained unfinished behavioral changes.
Notes
This is a broad style refactor. Review the helper extractions and branching rewrites separately from formatting and local renames. Dart string literal comparison found changes only in the metadata URL helper extraction; request URLs retain their previous values and encoding.
Coordinated PRs: server #13 and workspace #14. Merge the component PRs before integrating the workspace pointers.
Checklist