Skip to content

Refactor client code to the reviewed style - #43

Merged
Eoic merged 1 commit into
developmentfrom
feature/code-style-refactor
Oct 9, 2026
Merged

Eoic merged 1 commit into
developmentfrom
feature/code-style-refactor

Conversation

@Eoic

@Eoic Eoic commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Summary

Apply the maintainer's reviewed coding style across client code and tests: clearer local and callback names, braces around guards and loops, explicit branches in place of nested ternaries, focused metadata URL and OPDS validation helpers, and removal of redundant comments.

Keep consecutive single-line statements together and put blank lines around blocks and multiline statements. Preserve deliberate trailing commas with the existing 120-character formatter width. Document these conventions in AGENTS.md.

Testing

From the workspace root:

  • tools/papyrus check client: formatter, analyzer, and all four web bootstrap tests passed.
  • tools/papyrus test client: 1,604 passed, 19 skipped.
  • From client/app, ../../tools/flutter build web --dart-define-from-file=.dart_defines: passed.
  • git diff --check: passed.

The full suite and web build ran before the final whitespace correction. Static checks were repeated afterward; token comparison verified that the spacing correction changed no Dart tokens.

UI evidence

Not applicable. No intentional visual changes.

Compatibility and migration

No intended behavior, API, dependency, version, or storage changes. Reviewed samples were used as style references rather than copied directly because some contained unfinished behavioral changes.

Notes

This is a broad style refactor. Review the helper extractions and branching rewrites separately from formatting and local renames. Dart string literal comparison found changes only in the metadata URL helper extraction; request URLs retain their previous values and encoding.

Coordinated PRs: server #13 and workspace #14. Merge the component PRs before integrating the workspace pointers.

Checklist

  • The branch, commits, and pull request title follow the repository conventions.
  • The change is complete and limited to the agreed scope.
  • Relevant tests have been added or updated.
  • Formatting, analysis, and tests pass.
  • Documentation, UI evidence, and migration notes are included where relevant.
  • No credentials, personal data, copyrighted fixtures, or unrelated generated files are included.
  • The branch is up to date with its target branch.

Copilot AI balanced review requested due to automatic review settings October 9, 2026 23:28
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T23:33:01.923635Z 6b02c59 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Eoic
Eoic merged commit 0274e95 into development Oct 9, 2026
1 check passed
@Eoic
Eoic deleted the feature/code-style-refactor branch October 9, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants