Repository navigation
Conversation
edda1eb to
0970e69
Compare
|
/ddci trigger |
|
View all feedbacks in Devflow UI.
Tasks sourcing running asynchronously in workflow devflow:4924896d-a00c-476c-a539-b3c721df0f9f_47:01a1a763-25c5-7b53-9ea7-7b5e2b14c881 under run id 01a1a763-2e2d-7a17-b0cb-f742a5242fe9 |
There was a problem hiding this comment.
With SKIP_PIP_INSTALL unset, the Noble-based layer-publishing jobs still invoke system pip and abort under PEP 668 before publishing any layers.
🤖 Bits Code Review · Commit 0970e69
1ff3e17 to
628602f
Compare
|
This comment will be updated automatically if new data arrives. 🔗 Commit SHA: da42843 | Docs | View more details | Give us feedback! |
There was a problem hiding this comment.
More details
CI jobs now use digest-pinned Docker images with internal Buildx, apt-installed AWS tools, and Python virtual environments. Publishing exports SKIP_PIP_INSTALL=true, resolving the earlier Noble system-pip failure. No findings remain open. Full container and CI integration validation remains outstanding.
🤖 Bits Code Review · Commit 97c3648
| rules: | ||
| # Image-maintenance validation has no authorization to deploy Lambda services. | ||
| - if: '$CI_COMMIT_BRANCH == "ericlim/internal-buildx-modern-docker-20261103" || $CI_MERGE_REQUEST_SOURCE_BRANCH_NAME == "ericlim/internal-buildx-modern-docker-20261103"' | ||
| when: never |
There was a problem hiding this comment.
Do we want to commit these?
There was a problem hiding this comment.
indeed not thanks for the catch !
|
/gitlab resync-job-status |
|
View all feedbacks in Devflow UI.
47 jobs status updated and 0 skipped for a total of 47 jobs |
|
/ddci trigger |
|
View all feedbacks in Devflow UI.
Tasks sourcing running asynchronously in workflow devflow:c5593916-57f2-4b84-acd2-7682b01516c8_47:01a1e9cd-63ad-74b8-a2c4-503048e1a5b3 under run id 01a1e9cd-6d51-7c87-bfd6-8ff029fb845c |
|
@DataDog review |
There was a problem hiding this comment.
More details
The credential assignment preserves failed role assumptions, while CI tool installation uses a virtual environment for Noble’s managed Python. Execution of the image-based GitLab jobs remains unverified.
🤖 Bits Code Review · Commit da42843
purple4reina
left a comment
There was a problem hiding this comment.
There seem to be failures in the integration tests. https://gitlab.ddbuild.io/DataDog/datadog-lambda-python/-/jobs/2264147211
It's showing aws sts assume-role failed with Failed to connect to proxy URL: "http://127.0.0.1:15002"
|
Reopened as #894 from a branch in DataDog/datadog-lambda-python so repository CI can run. It retains SKIP_PIP_INSTALL=true and the removal of temporary validation/branch-guard changes. It also retains the corrected tests/integration path and fail-fast AWS role-assumption handling. The cited integration job could not connect to the runner Fabric proxy at 127.0.0.1:15002; proxy configuration is unchanged, and fresh CI will show whether that infrastructure failure persists. Leaving this PR open to preserve the review history. |
Use maintained
docker:27.3.1anddocker:29.4.0-noble-py3tags in CI instead of pipeline-specific images or fixed digests. Keep the Python virtual-environment setup andSKIP_PIP_INSTALL=truein layer publishing jobs so Noble does not attempt a system-pip install.Removed the temporary
validate-python-ci-toolsjob and all four branch-specific deployment guards following review. Existing CI rules, includingSKIP_E2E_TESTS, are restored.images#12612 is merged and both maintained shared images were rebuilt and published from master with internal Buildx v0.38.2-dd.3.
Validation: rendered the Go template locally and parsed the generated YAML using GitLab-compatible reused-anchor handling; all 28 publishing jobs retain the Python setup and pip skip flag, and the validation-only job is absent. All 44 affected integration, publishing and E2E jobs retain their original skip rules without a hardcoded branch exception. Shell syntax and diff checks pass. The new commit is signed and GitHub-verified; CI is enabled. Earlier candidate runs passed layer builds, size checks and unit tests.
Integration CI follow-up: install the existing test dependencies from
tests/integration(the oldintegration_testsdirectory no longer exists). Preserveaws sts assume-rolefailures instead of swallowing them insideexport, so runner proxy/authentication failures stop immediately. No tests are skipped and Fabric proxy settings are unchanged.Validation: Bash syntax and diff checks pass; local credential-success and credential-failure checks confirm exports and failure propagation. The pipeline template renders successfully. Fresh CI is enabled; the commit is signed and GitHub-verified.