Skip to content

ci: use internal Buildx v0.38.2-dd.3 builders - #865

Open
ericdog wants to merge 2 commits into
mainfrom
ci-image/internal-buildx-20261112
Open

ericdog wants to merge 2 commits into
mainfrom
ci-image/internal-buildx-20261112

Conversation

@ericdog

@ericdog ericdog commented Nov 12, 2026 •

Copy link
Copy Markdown

Use the maintained docker:20.10.13-jammy tag for CI image builds and builder validation. Log the selected Buildx version without rejecting future promoted releases.

The Python-enabled Docker 20.10 compatibility images in the generated layer pipeline remain pinned because they are new variants from images#12639. Their existing version check remains tied to that pinned artifact.

Publication prerequisite: images#12612 is still unmerged. Its newer Buildx client reaches these maintained tags only after source merge and normal default-branch image publication. Docker 27.3.1 is already published from master.

Mutable tags are intentional. New job image resolution follows the runner pull policy; existing running jobs and already-built derived images keep their current contents. Validation: diff checks and applicable YAML parsing pass; CI remains enabled on signed commits. No image promotion or deployment was performed.

@ericdog
ericdog requested a review from a team as a code owner November 12, 2026 14:05
@ericdog ericdog added the buildx-internal-rollout Internal Buildx adoption label Nov 12, 2026

@datadog-datadog-us1-prod datadog-datadog-us1-prod Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The pinned image manifests support the required runner architectures. Deployment-dependent E2E validation remains outstanding, and the source image PR must merge first.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 99c3e08

@purple4reina purple4reina left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Could it follow the same shape as DataDog/serverless-e2e-tests#396 and DataDog/datadog-lambda-python#882?

  1. Drop the ci-image/* when: never rules. With them, any branch named ci-image/… skips layer publishing and e2e and still goes green, and that includes this PR's own branch.
  2. Drop validate-ci-builder and validate-python-ci-tools. They were useful during the rollout but would run in every pipeline forever.
  3. Point e2e-test-status at a maintained tag instead of the v152575203-…-buildx-0382@sha256:… candidate digest. It only runs poll_e2e.sh.
  4. Version the CI image. The real Buildx change happens at merge. Editing .gitlab-ci.yml starts the ci image job, which rebuilds ci/datadog-lambda-js:latest from docker:24.0.5 (now on 0.38.2-dd.3; today's :latest is 0.37.0-dd.2) and overwrites :latest in place. This PR's pipeline never built or tested that image, and afterwards there's no old tag to roll back to. Could DOCKER_TARGET_VERSION / CI_DOCKER_TARGET_VERSION move from latest to a versioned tag, so the current image stays available?
  5. Run the full pipeline, including sandbox publish and e2e, from a branch that doesn't start with ci-image/.

Also, the description still says images#12612 is unmerged. docker:20.10.13-jammy and docker:24.0.5 were both republished with 0.38.2-dd.3 on 2026-11-17.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildx-internal-rollout Internal Buildx adoption

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants