Repository navigation
Conversation
There was a problem hiding this comment.
More details
The pinned image manifests support the required runner architectures. Deployment-dependent E2E validation remains outstanding, and the source image PR must merge first.
🤖 Bits Code Review · Commit 99c3e08
purple4reina
requested changes
Nov 18, 2026
purple4reina
left a comment
Contributor
There was a problem hiding this comment.
Thanks for working on this. Could it follow the same shape as DataDog/serverless-e2e-tests#396 and DataDog/datadog-lambda-python#882?
- Drop the
ci-image/*when: neverrules. With them, any branch namedci-image/…skips layer publishing and e2e and still goes green, and that includes this PR's own branch. - Drop
validate-ci-builderandvalidate-python-ci-tools. They were useful during the rollout but would run in every pipeline forever. - Point
e2e-test-statusat a maintained tag instead of thev152575203-…-buildx-0382@sha256:…candidate digest. It only runspoll_e2e.sh. - Version the CI image. The real Buildx change happens at merge. Editing
.gitlab-ci.ymlstarts theci imagejob, which rebuildsci/datadog-lambda-js:latestfromdocker:24.0.5(now on0.38.2-dd.3; today's:latestis0.37.0-dd.2) and overwrites:latestin place. This PR's pipeline never built or tested that image, and afterwards there's no old tag to roll back to. CouldDOCKER_TARGET_VERSION/CI_DOCKER_TARGET_VERSIONmove fromlatestto a versioned tag, so the current image stays available? - Run the full pipeline, including sandbox publish and e2e, from a branch that doesn't start with
ci-image/.
Also, the description still says images#12612 is unmerged. docker:20.10.13-jammy and docker:24.0.5 were both republished with 0.38.2-dd.3 on 2026-11-17.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the maintained
docker:20.10.13-jammytag for CI image builds and builder validation. Log the selected Buildx version without rejecting future promoted releases.The Python-enabled Docker 20.10 compatibility images in the generated layer pipeline remain pinned because they are new variants from images#12639. Their existing version check remains tied to that pinned artifact.
Publication prerequisite: images#12612 is still unmerged. Its newer Buildx client reaches these maintained tags only after source merge and normal default-branch image publication. Docker 27.3.1 is already published from master.
Mutable tags are intentional. New job image resolution follows the runner pull policy; existing running jobs and already-built derived images keep their current contents. Validation: diff checks and applicable YAML parsing pass; CI remains enabled on signed commits. No image promotion or deployment was performed.