Skip to content

Use maintained CI images with internal Buildx - #894

Open
ericdog wants to merge 1 commit into
mainfrom
eric-lim/internal-buildx-ci-20261119
Open

ericdog wants to merge 1 commit into
mainfrom
eric-lim/internal-buildx-ci-20261119

Conversation

@ericdog

@ericdog ericdog commented Nov 19, 2026

Copy link
Copy Markdown

What does this PR do?

Use maintained, unpinned shared Docker CI images containing internal Buildx: docker:27.3.1 for Docker-only jobs and docker:29.4.0-noble-py3 for Python/AWS jobs. Configure the latter's managed Python through a virtual environment and retain SKIP_PIP_INSTALL=true for layer publishing.

Preserve failed AWS role assumptions instead of swallowing their exit status, and install integration dependencies from the existing tests/integration directory.

Motivation

Replaces #882 with a branch in DataDog/datadog-lambda-python, as requested in review because fork PRs do not run this repository's CI. Keeps the reviewed implementation, rebased onto current main, including its centralized Python runtime list. No temporary validation jobs, branch-specific skip rules, or formatting-only changes.

Testing Guidelines

  • Rendered the Go CI template locally with all current runtime/environment inputs and parsed 138 pipeline entries; all 32 layer-publishing jobs retain the Python setup and pip skip flag.
  • Compared generated jobs against main: existing rules, needs, dependencies, scripts and matrix settings remain unchanged except the corrected integration dependency path.
  • Bash syntax, git diff --check, and mocked AWS credential success/failure propagation pass.
  • Normal CI remains enabled; this PR does not claim integration tests have passed yet.

Additional Notes

The previous integration run 2264147211 failed to connect to its runner's Fabric proxy at 127.0.0.1:15002, then continued without AWS credentials and tried the obsolete integration_tests directory. The credential exit-status and directory fixes are retained here. Fabric proxy settings are unchanged; a proxy failure may still require CI infrastructure investigation.

The shared image source changes in https://github.com/ddoghq/images/pull/12612 are merged. No manual publishing/signing/deployment jobs were triggered while preparing this change.

Types of Changes

  • Misc (CI image maintenance)

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

The replacement image metadata supports the required CI tooling, and AWS role-assumption failures propagate instead of being swallowed. Full CI execution remains unverified.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit 7845cec

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildx-internal-rollout Internal Buildx CI adoption

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants