Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
More details
The replacement image metadata supports the required CI tooling, and AWS role-assumption failures propagate instead of being swallowed. Full CI execution remains unverified.
🤖 Bits Code Review · Commit 7845cec
purple4reina
approved these changes
Nov 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use maintained, unpinned shared Docker CI images containing internal Buildx:
docker:27.3.1for Docker-only jobs anddocker:29.4.0-noble-py3for Python/AWS jobs. Configure the latter's managed Python through a virtual environment and retainSKIP_PIP_INSTALL=truefor layer publishing.Preserve failed AWS role assumptions instead of swallowing their exit status, and install integration dependencies from the existing
tests/integrationdirectory.Motivation
Replaces #882 with a branch in DataDog/datadog-lambda-python, as requested in review because fork PRs do not run this repository's CI. Keeps the reviewed implementation, rebased onto current
main, including its centralized Python runtime list. No temporary validation jobs, branch-specific skip rules, or formatting-only changes.Testing Guidelines
main: existing rules, needs, dependencies, scripts and matrix settings remain unchanged except the corrected integration dependency path.git diff --check, and mocked AWS credential success/failure propagation pass.Additional Notes
The previous integration run 2264147211 failed to connect to its runner's Fabric proxy at
127.0.0.1:15002, then continued without AWS credentials and tried the obsoleteintegration_testsdirectory. The credential exit-status and directory fixes are retained here. Fabric proxy settings are unchanged; a proxy failure may still require CI infrastructure investigation.The shared image source changes in https://github.com/ddoghq/images/pull/12612 are merged. No manual publishing/signing/deployment jobs were triggered while preparing this change.
Types of Changes