Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's GuideThis staged PR adds evidence-bound successor-claim reconciliation, a fail-closed structured-occurrence adapter, and an opt-in v2 JSON representation validator with preserved rights gates, while recording a partially completed public pilot and explicitly retaining all full-replay, release, human-review, and acceptance holds. Sequence diagram for fail-closed structured-occurrence reconciliationsequenceDiagram
participant CLI as Recovery CLI
participant Adapter as Structured adapter
participant Sources as Pinned source artifacts
participant Claims as Claim receipts
participant Policy as Review policy and evidence
participant Accounting as Recovery accounting
CLI->>Adapter: reconciliation_accounting()
Adapter->>Sources: Re-extract and hash complete structured set
Sources-->>Adapter: Pinned occurrences and source snapshots
Adapter->>Claims: Validate associations and claim dispositions
Claims-->>Adapter: Validated claim IDs and input digests
Adapter->>Policy: Validate authority, reviewers, chronology, and evidence
Policy-->>Adapter: Complete occurrence receipts or failure
Adapter->>Accounting: Return completed denominator and unresolved status
Accounting-->>CLI: Structured reconciliation result
Sequence diagram for v2 JSON string representation validationsequenceDiagram
participant Register as V2 publication register
participant Publication as publication_accounting()
participant Parser as decoded_json_expression()
participant Output as Digest-bound JSON output
participant Gates as Rights and distribution gates
Register->>Publication: Submit JSON_STRING use and representation metadata
Publication->>Output: Validate raw output digest and byte spans
Publication->>Parser: Resolve JSON pointer and token bounds
Parser->>Output: Parse complete UTF-8 JSON and reject ambiguity
Output-->>Parser: Selected string token
Parser-->>Publication: Decoded expression and decoded digest
Publication->>Publication: Compare decoded expression with exact source span
Publication->>Gates: Preserve independent rights and acceptance checks
Gates-->>Publication: Rights decision remains separate from equality
Publication-->>Register: V2 accounting with raw and decoded outcomes
State diagram for staged public pilot and release readinessstateDiagram-v2
[*] --> Staged
Staged --> PilotObserved: Public pilot execution and rollback recorded
PilotObserved --> MainRestored: Main restored and rule Disabled
MainRestored --> HoldsRemain: Missing pilot cases, full replay, and human gates
HoldsRemain --> ReleaseReady: Future acceptance, merged-main checks, rights, and distribution approval
ReleaseReady --> [*]
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
4444J99
added a commit
that referenced
this pull request
Oct 12, 2026
Retain PR #497's independently published migration implementation and identical current inventory. Preserve the initial approved PR #503 payload in the first-parent history while integrating 25affa7. Narrow the delta to the independently reviewed A3 reference stability guard, two regression tests covering four observed failure cases, and supporting review/verification evidence. Both full workload states and all 707 tests pass locally; source and receipt acceptance remain pending.
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2026-10-12 workload migration — current head 25affa7
The workload CI defect is repaired in
25affa78bcbf16e89667cbe3cbcfbc3a7fa05006, whose parent isafdd2ffe03bd840516947a9256ff9aea380335fb. PR #497 remains draft and dependent on #496 at unchanged heada9ab644a9577083fc130c9efa4ec249632a22dda. GES v0.2 remains Staged and unfinished.The historical workload now reproduces from its explicitly preserved membership. A separate current inventory and independently pinned transition require exactly the five approved WA successor additions, preserve every old document byte and family/receipt association, and reject unrelated additions or changed inputs. The original full-directory check remains the default. Both historical and complete-current checks are required by the real-data tests and Toolkit workflow.
Verified results at this head
Observed at 2026-10-12 19:40:26 UTC:
MATCH, and successful validation, compilation and generated-view parity.MATCH; complete argument arrays, timestamps, exit codes and output are preserved in the execution record./root/accounting_reviewagent subsequently reviewed the complete output and exact software/evidence files. This supplies software and metadata review.Execution, publication and lease closeout
The native checkout matched the reviewed source fingerprints, and the final staged whitespace check, normal commit and normal push all exited 0. Remote branch readback matched
25affa78bcbf16e89667cbe3cbcfbc3a7fa05006;git status --porcelainwas empty at 19:37:52 UTC.The final controller release returned
allowed: truefor writer lease83f0a3de801148e78c5d6f94a4df31b0, ownerchatgpt-ges-workload-20261012-b970b9876653, actual PID56261, surfacechatgpt:workload-commit-tranche. Its response listed no remaining leases. The publication tranche began at19:37:12.430544Z, retained a 600-second limit across retries, and finished after 40.555 seconds. The previous metadata tranche and its original deadline remain recorded; historical cumulative usage is UNKNOWN_NOT_RESET.The evidence records the earlier driver's missing release receipt separately from successful child verification results. Publication guards also caught extra terminal newlines in review copies/new evidence; the independent reviewer confirmed the exact one-byte differences, and the native verification record was preserved. No check or hook was bypassed.
Remaining holds
The latest heavy acquisition attempt, at 19:20:03 UTC, was denied for
swap-fraction; its pressure observation at19:20:05.143058Zrecorded 11,739,070,464 swap bytes on a 16 GiB host and vitalsthrottle. A later pressure observation returned by the final writer release was timestamped19:36:09.252829Zand recorded 7,142,249,594 swap bytes with vitalsshed. No heavy lease was acquired and no full native authenticated source replay was launched.The broader historical ledger's 2,164 validated dispositions and conditional 2,174 / 59,767 unresolved expectation are separate from the 474 workload receipt subjects. No fresh broader reconciliation accounting or replacement envelope is claimed. Issuance still requires the original authorized actors or an authentic renewed grant covering current actors, with no identity substitution or backdating.
Remaining adapters/synthesis, retained-body authentication, complete public disposable pilot evidence, final publication clearance, human code/security review, owner acceptance and merged-main verification remain open. Private support remains unverified.
Full repair evidence: migration README, transition contract, and publication preparation.
Earlier staged implementation record
Scope
Dependent implementation tranche based on #496 at a9ab644. The PR targets
wave/wa-publication-20261009so #496 retains its declared scope and unchangedhead. After its governed acceptance, retarget this tranche to main; do not replay
#495, which is already an ancestor. This PR is Staged, not Verified or release-ready.
reviewed semantic dispositions and full metadata digest/carryforward-subject audit.
Preserve historical claims and receipts; replacement envelopes remain unissued.
v2 schema and unchanged independent rights, human and distribution gates.
Pilot main is restored and rule Disabled; private support is not established.
Earlier observed verification
100 focused tests pass: structured reconciliation 15, JSON representation 8,
publication use 31, completion milestones 21, structured reference review 25.
V2 JSON Schema validation plus 14 synthetic documents pass. Pinned WA source spans
and actual GHQR decoded expression comparison pass.
git diff --checkpasses.Independent agent code review found three issues; regression tests and fixes were
subsequently rechecked. Agent review does not replace required human review.
Holds
Heavy host admission denied full suite/corpus replay and prescribed governance
checks. No current full reconciliation accounting or accepted control is claimed.
Remaining evidence adapters, six-source extraction, retained-body authentication,
full pilot matrix, final release-file inventory/rights, human code/security review,
owner acceptance, main checks/CI and distribution/tagging all remain open.
The durable evidence and exact results are in
evidence/v02-finish-20261010/README.md; the approved implementation plan is.codex/plans/2026-10-10-finish-ges-v02.md.Summary by Sourcery
Advance GES v0.2 with fail-closed reconciliation and approved JSON representation support while documenting public pilot evidence and retaining all release readiness gates.
New Features:
Bug Fixes:
Enhancements:
Documentation:
Tests:
Chores: