Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's GuideIntroduces a hash-bound, read-only envelope comparator and retained-draft audit, with tests and operational documentation that preserve decision integrity while explicitly keeping authorization, issuance, source verification, and accounting as separate subsequent gates. Sequence diagram for read-only reconciliation envelope comparisonsequenceDiagram
participant CLI
participant Comparator as reconciliation_envelopes
participant Draft
participant Policy
participant Receipts
CLI->>Comparator: compare_envelopes(draft_bytes, expected_sha256, receipts, policy)
Comparator->>Draft: Verify SHA-256 and draft structure
Comparator->>Policy: _validate_policy(policy, bindings)
Comparator->>Receipts: Compare membership and substantive fields
Comparator->>Receipts: Validate authorized distinct roles
Comparator->>Receipts: Validate reconciled_at <= reviewed_at <= now()
Comparator-->>CLI: MATCH_UNDER_SUPPLIED_POLICY or validation error
Note over Comparator: No authorization, issuance, source replay, or accounting credit
Flow diagram for retained draft integrity auditflowchart TD
A[Load retained replay manifest] --> B[Verify artifact hashes and byte lengths]
B --> C[Verify hash-pinned nonissued draft]
C --> D[Reconstruct subjects from claim documents]
D --> E[Verify exact decision membership and bindings]
E --> F[Compare carried decisions and fields]
F --> G[Write retained-draft readiness result]
G --> H[No issuance or accounting credit]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
RECEIPT: no-eligible-work Trigger: workflow success on SHA 0d9934b (Source acquisition and coverage). Checks: standing-go not confirmed (no STANDING_GO.md at root, no 'standing-go' label, no comment containing 'standing go authorized'). No existing RECEIPT on this SHA. PR is draft; identity-lint / other blocking checks not claimed as honest green beyond observed CI success. No concrete progress step taken. |
…iation evidence Record that Toolkit validation completed successfully on the current head after authorized partial reconciliation evidence was added.
|
Progress receipt: noted successful new-head Toolkit validation in evidence/v02-authorized-reconciliation-20261012/README.md (commit 8642b78 on exact prior head). Small documentation polish only; no code, force, or bypass. |
…reconciliation head Update the retained evidence note to the exact current head after Toolkit validation succeeded.
Record the successful workflow run for Source acquisition and coverage on head a6a163e as a small polish after green CI.
|
Green progress step: noted successful Source acquisition and coverage on current head in evidence/v02-authorized-reconciliation-20261012/README.md (commit 4bb4b57). Exact-head update; no force-push or bypass. |
Record the successful Toolkit validation workflow run on head 4bb4b57 as a small polish after green CI.
|
Green progress step: updated evidence/v02-authorized-reconciliation-20261012/README.md to note successful Toolkit validation on head 4bb4b57 (run https://github.com/4444J99/github-engineering-standards/actions/runs/38313579565). Commit: d28a76d. |
Receipt: updated evidence README to note green Source acquisition and coverage workflow on head 4bb4b57 (https://github.com/4444J99/github-engineering-standards/actions/runs/38313514024). No functional change; staged partial reconciliation remains open.
Record the successful Toolkit validation workflow run on head a817e51 as a small polish after green CI. Exact-head update; no functional change.
|
Green progress step: updated evidence/v02-authorized-reconciliation-20261012/README.md to note successful Toolkit validation on head a817e51 (run https://github.com/4444J99/github-engineering-standards/actions/runs/38313809675). Commit: 580c2d9. Exact-head; no force-push or bypass. |
Record the successful Toolkit validation workflow run on head 580c2d9 as a small polish after green CI. Exact-head update; no functional change.
Record the successful Toolkit validation workflow run on head 8f86f14 as a small polish after green CI. Exact-head update; no functional change.
Record the successful Toolkit validation workflow run on head 8f86f14 as a small polish after green CI. Exact-head update; no functional change.
Record the successful Source acquisition and coverage workflow run on head 580c2d9 as a small polish after green CI. Exact-head update; no functional change.
Recover five exact A3 metadata members from authenticated CI artifacts, preserve existing authorized receipts, and record the successful full recovery with unchanged input hashes. Add early recovery input validation and seven regressions, including trusted Darwin aliases. Correct current runbooks and retain explicit open v0.2 acceptance gates. Validation: 721 tests; 95-control validation; compilation and generated-file checks; independent software and recovery evidence review.
The source-only replay used by #506/#507 could validate claim provenance but lacked the frozen candidate ledger required by the full recovery reporter. This PR now restores authenticated corpus inputs, completes the actual recovery integration, and fails early with a clear diagnostic when required recovery inputs are missing.
Current result
The missing-ledger integration failure is resolved at 5f552e7. The final reviewed-code
ges.recoveryexecution exited 0 in 32.009 seconds, with all 1,654 input-closure entries and the execution driver unchanged.mapping_complete=false. Dispositions remain MAP 382; SPECIALIZE 57; CONFLICT 3; REFERENCE 1,721; EXCLUDED_WITH_REASON 11. A successful reporter exit means a valid report was produced; all nine acceptance gates remain open.What changed
ges.recoverycheck for required corpus and source files, with snapshots required when claim documents need them. Missing files, directories in place of files, and untrusted symlinks produce one actionable error before expensive processing. Existing trusted Darwin aliases remain supported.Existing authorization and receipts
The original scoped owner grant, actual issuance, and distinct authorized final-envelope review remain unchanged. The full issued-ledger byte digest remains
b4147bf94b13d18188b7acc775c1f7508f1653f2737bcecc7f27920afe58b73f. This repair reuses those 2,174 receipts without new issuance, actor substitution, timestamp changes, or additional semantic credit.The initial grant and accounting evidence under
evidence/v02-authorized-reconciliation-20261012/remain historical records. Its missing-corpus failure is superseded by the successful integration above.Validation
ges.claim_reviewexecution passed in 9.341 seconds.5f552e7and matched the reviewed local files byte for byte. Concurrent README updates were preserved.5f552e7: Toolkit validation, run 38315120020 succeeded on Python 3.11 and 3.13; Source acquisition and coverage, run 38315119795 succeeded. Exact-head readback was confirmed on October 12 at 22:13 UTC. No additional status-only commit was created.Remaining acceptance work
The report still shows 59,767 unresolved claim dispositions, 10,067 missing artifact disposition receipts, no supplied certifications for 605 structured occurrences, and 0 accepted canonical controls out of 95. Source-to-claim omission review, synthesis/adoption/binding/native adapters, the full pilot behavior matrix, exact-use publication decisions and release inventory, original capsule/rendered-body authentication, and final owner acceptance remain open. The two JSON-expression rights decisions remain on HOLD.
Human code review, applicable security review, governed merging, merged-main verification, and owner acceptance remain required by repository governance. The independent agent reviews do not substitute for those approvals. No merge, release, control adoption, pilot activation, or estate rollout occurred.
Stack: #496 → #497 → #503 → #506 → this draft. Estate rollout remains a separate, nonblocking v0.2 track. This repair resolves recovery execution; it does not establish v0.2 acceptance.