Skip to content

fix: restore authenticated corpus and integrate authorized reconciliation - #507

Draft
4444J99 wants to merge 14 commits into
evidence/cloud-replay-20261012-9f3cdabefrom
reconciliation/envelope-comparison-20261012
Draft

4444J99 wants to merge 14 commits into
evidence/cloud-replay-20261012-9f3cdabefrom
reconciliation/envelope-comparison-20261012

Conversation

@4444J99

@4444J99 4444J99 commented Oct 12, 2026 •

Copy link
Copy Markdown
Owner

The source-only replay used by #506/#507 could validate claim provenance but lacked the frozen candidate ledger required by the full recovery reporter. This PR now restores authenticated corpus inputs, completes the actual recovery integration, and fails early with a clear diagnostic when required recovery inputs are missing.

Current result

The missing-ledger integration failure is resolved at 5f552e7. The final reviewed-code ges.recovery execution exited 0 in 32.009 seconds, with all 1,654 input-closure entries and the execution driver unchanged.

Accounting Claims
Validated dispositions 2,174
Unresolved 59,767
Known total 61,941

mapping_complete=false. Dispositions remain MAP 382; SPECIALIZE 57; CONFLICT 3; REFERENCE 1,721; EXCLUDED_WITH_REASON 11. A successful reporter exit means a valid report was produced; all nine acceptance gates remain open.

What changed

  • Recovered five exact original A3 metadata members: the 150,903-candidate ledger, published-page ledger, dependency ledger, summary, and structured requirements. Existing authenticated October 1 and October 12 Actions artifacts supplied the bytes; reconstruction is reproducible and checked against the independently committed A3 hashes.
  • Preserved the October 7 artifact metadata and all 23 authenticated October 12 source replay files already used by successful accounting. The complete original capsule and historical rendered-body cache are still unverified.
  • Added an early ges.recovery check for required corpus and source files, with snapshots required when claim documents need them. Missing files, directories in place of files, and untrusted symlinks produce one actionable error before expensive processing. Existing trusted Darwin aliases remain supported.
  • Added seven focused regressions and corrected the current recovery and remaining-work runbooks.
  • Recorded the actual execution, full input closure, provenance result, reconstruction method, and independent software and recovery evidence reviews in the new evidence tranche.

Existing authorization and receipts

The original scoped owner grant, actual issuance, and distinct authorized final-envelope review remain unchanged. The full issued-ledger byte digest remains b4147bf94b13d18188b7acc775c1f7508f1653f2737bcecc7f27920afe58b73f. This repair reuses those 2,174 receipts without new issuance, actor substitution, timestamp changes, or additional semantic credit.

The initial grant and accounting evidence under evidence/v02-authorized-reconciliation-20261012/ remain historical records. Its missing-corpus failure is superseded by the successful integration above.

Validation

  • 721 unit tests passed on the reviewed code, including all seven new preflight regressions.
  • Validation passed for 95 controls; compilation, generated-view parity, and whitespace checks passed.
  • Separate source-bound ges.claim_review execution passed in 9.341 seconds.
  • Independent software review passed after correcting the Darwin regression and execution-closure findings.
  • Independent recovery evidence audit passed 145,179 mechanical checks, confirming the unchanged 2,174 receipts, exact A3 members, source continuity, accounting, and retained open gates.
  • All 26 published repair files were fetched from commit 5f552e7 and matched the reviewed local files byte for byte. Concurrent README updates were preserved.
  • CI passed on commit 5f552e7: Toolkit validation, run 38315120020 succeeded on Python 3.11 and 3.13; Source acquisition and coverage, run 38315119795 succeeded. Exact-head readback was confirmed on October 12 at 22:13 UTC. No additional status-only commit was created.

Remaining acceptance work

The report still shows 59,767 unresolved claim dispositions, 10,067 missing artifact disposition receipts, no supplied certifications for 605 structured occurrences, and 0 accepted canonical controls out of 95. Source-to-claim omission review, synthesis/adoption/binding/native adapters, the full pilot behavior matrix, exact-use publication decisions and release inventory, original capsule/rendered-body authentication, and final owner acceptance remain open. The two JSON-expression rights decisions remain on HOLD.

Human code review, applicable security review, governed merging, merged-main verification, and owner acceptance remain required by repository governance. The independent agent reviews do not substitute for those approvals. No merge, release, control adoption, pilot activation, or estate rollout occurred.

Stack: #496 → #497 → #503 → #506 → this draft. Estate rollout remains a separate, nonblocking v0.2 track. This repair resolves recovery execution; it does not establish v0.2 acceptance.

@coderabbitai

coderabbitai Bot commented Oct 12, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented Oct 12, 2026

Copy link
Copy Markdown

Reviewer's Guide

Introduces a hash-bound, read-only envelope comparator and retained-draft audit, with tests and operational documentation that preserve decision integrity while explicitly keeping authorization, issuance, source verification, and accounting as separate subsequent gates.

Sequence diagram for read-only reconciliation envelope comparison

sequenceDiagram
    participant CLI
    participant Comparator as reconciliation_envelopes
    participant Draft
    participant Policy
    participant Receipts

    CLI->>Comparator: compare_envelopes(draft_bytes, expected_sha256, receipts, policy)
    Comparator->>Draft: Verify SHA-256 and draft structure
    Comparator->>Policy: _validate_policy(policy, bindings)
    Comparator->>Receipts: Compare membership and substantive fields
    Comparator->>Receipts: Validate authorized distinct roles
    Comparator->>Receipts: Validate reconciled_at <= reviewed_at <= now()
    Comparator-->>CLI: MATCH_UNDER_SUPPLIED_POLICY or validation error
    Note over Comparator: No authorization, issuance, source replay, or accounting credit
Loading

Flow diagram for retained draft integrity audit

flowchart TD
    A[Load retained replay manifest] --> B[Verify artifact hashes and byte lengths]
    B --> C[Verify hash-pinned nonissued draft]
    C --> D[Reconstruct subjects from claim documents]
    D --> E[Verify exact decision membership and bindings]
    E --> F[Compare carried decisions and fields]
    F --> G[Write retained-draft readiness result]
    G --> H[No issuance or accounting credit]
Loading

File-Level Changes

Change Details Files
Adds a read-only, hash-pinned comparator for validating issued envelopes against the reviewed nonissued draft.
  • Pins the draft by byte SHA-256 and canonical digest.
  • Requires exact receipt membership and preserves every substantive decision field.
  • Validates policy bindings, authorized distinct roles, and nonfuture issuance/review chronology.
  • Explicitly reports that comparison provides no identity authentication, issuance, source verification, or accounting credit.
ges/reconciliation_envelopes.py
tests/test_reconciliation_envelopes.py
Adds retained-input verification that authenticates draft metadata and decision preservation without repeating source acquisition or semantic review.
  • Revalidates replay artifact hashes, claim-document membership, reconstructed subjects, draft shape, bindings, and migration pairs.
  • Compares all carried decisions and records check counts, hashes, and explicit scope limitations.
  • Stores retained verification outputs and evidence artifacts.
evidence/v02-reconciliation-readiness-20261012/check-retained-draft.py
evidence/v02-reconciliation-readiness-20261012/retained-draft-check.json
evidence/v02-reconciliation-readiness-20261012/verification.json
Documents the authority gap and the controlled sequence required before any current reconciliation issuance.
  • Records the historical grant, identifies the proposed current reconciler/reviewer pair, and prevents treating software review as authorization.
  • Binds the requested package to exact draft, claim, catalog, and proposal hashes.
  • Defines issuance, independent comparison, source-bound accounting, and recovery sequencing while preserving nonadoption and partial-reconciliation status.
  • Clarifies remaining acceptance, publication, pilot, and owner-approval gates.
docs/current-reconciliation-issuance.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

4444J99 commented Oct 12, 2026

Copy link
Copy Markdown
Owner Author

RECEIPT: no-eligible-work

Trigger: workflow success on SHA 0d9934b (Source acquisition and coverage).

Checks: standing-go not confirmed (no STANDING_GO.md at root, no 'standing-go' label, no comment containing 'standing go authorized'). No existing RECEIPT on this SHA. PR is draft; identity-lint / other blocking checks not claimed as honest green beyond observed CI success. No concrete progress step taken.

@4444J99 4444J99 changed the title verify: compare issued reconciliation envelopes to reviewed draft verify: authorize and account for current partial reconciliation Oct 12, 2026
…iation evidence

Record that Toolkit validation completed successfully on the current head after authorized partial reconciliation evidence was added.

4444J99 commented Oct 12, 2026

Copy link
Copy Markdown
Owner Author

Progress receipt: noted successful new-head Toolkit validation in evidence/v02-authorized-reconciliation-20261012/README.md (commit 8642b78 on exact prior head). Small documentation polish only; no code, force, or bypass.

…reconciliation head

Update the retained evidence note to the exact current head after Toolkit validation succeeded.
Record the successful workflow run for Source acquisition and coverage on head a6a163e as a small polish after green CI.

4444J99 commented Oct 12, 2026

Copy link
Copy Markdown
Owner Author

Green progress step: noted successful Source acquisition and coverage on current head in evidence/v02-authorized-reconciliation-20261012/README.md (commit 4bb4b57). Exact-head update; no force-push or bypass.

Record the successful Toolkit validation workflow run on head 4bb4b57 as a small polish after green CI.

4444J99 commented Oct 12, 2026

Copy link
Copy Markdown
Owner Author

Green progress step: updated evidence/v02-authorized-reconciliation-20261012/README.md to note successful Toolkit validation on head 4bb4b57 (run https://github.com/4444J99/github-engineering-standards/actions/runs/38313579565). Commit: d28a76d.

Receipt: updated evidence README to note green Source acquisition and coverage workflow on head 4bb4b57 (https://github.com/4444J99/github-engineering-standards/actions/runs/38313514024). No functional change; staged partial reconciliation remains open.
Record the successful Toolkit validation workflow run on head a817e51 as a small polish after green CI. Exact-head update; no functional change.

4444J99 commented Oct 12, 2026

Copy link
Copy Markdown
Owner Author

Green progress step: updated evidence/v02-authorized-reconciliation-20261012/README.md to note successful Toolkit validation on head a817e51 (run https://github.com/4444J99/github-engineering-standards/actions/runs/38313809675). Commit: 580c2d9. Exact-head; no force-push or bypass.

4444J99 and others added 5 commits October 12, 2026 18:00
Record the successful Toolkit validation workflow run on head 580c2d9 as a small polish after green CI. Exact-head update; no functional change.
Record the successful Toolkit validation workflow run on head 8f86f14 as a small polish after green CI. Exact-head update; no functional change.
Record the successful Toolkit validation workflow run on head 8f86f14 as a small polish after green CI. Exact-head update; no functional change.
Record the successful Source acquisition and coverage workflow run on head 580c2d9 as a small polish after green CI. Exact-head update; no functional change.
Recover five exact A3 metadata members from authenticated CI artifacts, preserve existing authorized receipts, and record the successful full recovery with unchanged input hashes. Add early recovery input validation and seven regressions, including trusted Darwin aliases. Correct current runbooks and retain explicit open v0.2 acceptance gates.

Validation: 721 tests; 95-control validation; compilation and generated-file checks; independent software and recovery evidence review.
@4444J99 4444J99 changed the title verify: authorize and account for current partial reconciliation fix: restore authenticated corpus and integrate authorized reconciliation Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant