Repository navigation
test(roundtrip): pin reparse-equivalence and diagnostic text for the fidelity regressions - #437
Merged
Merged
Conversation
…fidelity regressions The audit fixes already reject or correct each of the five roundtrip defects; the tests now prove the issue's completion contract: re-emitted text reparses to an equivalent program for the escape and forward- reference cases, and the invalid inputs fail with diagnostics that name the offending index, declaration name, or duplicate block. The dotted/ percent declaration-name item is recorded as reproduced and rejected. Fixes #428
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The five roundtrip-fidelity defects were fixed in the audit batch; this change closes the remaining gap against the issue's acceptance criteria by pinning the outcome contract in the regression tests rather than only the individual assertions:
assert_emit_round_trip, so the emitted text must reparse to an equivalent program and re-emit to a fixed point — the issue's "reparses to an equal program" criterion.settingsblock): the tests now assert the diagnostics name the offending construct (integer index,duplicate 'settings' block) instead of only assertingis_err.a.b,a % b): recorded as reproduced and rejected — the diagnostic names the unreferenceable name.Verification
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test -p workshop-rs --lib— all greenWait-family emit outputs remain clean;1.9,4294967296,-1indexes anda.b/a % bnames all fail withmalformed:diagnostics; duplicatesettingsfails withmalformed: duplicate 'settings' blockgit diff --checkFixes #428