Repository navigation
Recurring defect class: emitted text is not verified by reparse #453
Description
Readiness: needs-decision — owner picks a prevention home.
Class
Tests asserted emitted strings without feeding emitter output back through the parser, so emit/parse stages drifted. Asserting the emitted text alone does not catch output the frontend reads differently.
Evidence
- Refs fix(settings): emit an empty Verbatim member without a trailing space #398 (2026-10-09) — an empty verbatim member emitted a trailing space the source never carried; post-merge follow-up to Refs feat(settings): carry undeclared settings members verbatim #396.
- Refs fix(settings): keep a bare 'name:' member from consuming the next line #404 (2026-10-09, Refs An empty settings member consumes the following line #402) — a bare
name:member absorbed the next line; the existing round-trip test placed the empty member last and never re-parsed the emitted text. - Refs fix: adversarial audit — parser, emitter, settings, CLI defects incl. localized round-trip #433 (2026-10-13) — audit fidelity batch: rule-name escapes that reparse differently, declaration indexes truncating/saturating via
as u32, silently dropped duplicatesettingsblocks, opaque-string escapes. - Refs test(lexer): pin BOM emission parity and span coordinates #436, Refs test(roundtrip): pin reparse-equivalence and diagnostic text for the fidelity regressions #437 (2026-10-13, Refs Lexer rejects a leading UTF-8 BOM #427, Refs Roundtrip fidelity: rule-name escapes, declaration indexes, duplicate settings blocks, forward variable references, opaque string escapes #428) — pinning tests for BOM parity/span coordinates and reparse-equivalence/diagnostic text, covering defects the merged code already shipped.
Ask
wrightkit/.github docs/testing-policy.md already lists "parse -> emit -> parse preserving declared semantics" as a preferred invariant and #437 added the pinning tests. Owner decides whether a systematic reparse harness over the emit surface is still needed or coverage is now sufficient.
Recorded in docs/LESSONS.md via the merged-work retrospective.
Activity
e54-bot commentedon Oct 15, 2026
Decision (owner):
AGENTS.md.e54-bot commentedon Oct 17, 2026
Retrospective update — prevention appears landed:
docs/testing-policy.mdalready lists parse→emit→parse, roundtrip regressions cover the fidelity batch via #437, andAGENTS.mdgained the "Emitted output is reparsed" contract rule via #457. The lesson entry was pruned in #475; leaving the close decision to the owner.e54-bot commentedon Oct 18, 2026
Closing: the 'Emitted output is reparsed' rule is in AGENTS.md (#457) and roundtrip regressions landed (#437). No harness, per the owner decision; revisit only if the class recurs.
e54-bot commentedon Oct 20, 2026
Recurrence 2026-10-19, in a contract-identifier position: Refs #499 (fixes #493) —
rule-content-v1passed the WIR call name through, emitting the global chase's catalog id for player-variable chases; the fix adds a contract test that fails when a rendered call id resolves throughlookupto a different entry.Same-day cross-repository instance in wrightkit/wright#808 (a diagnostic code built from a phrased kind; the space broke the GitHub annotation shape). Escalated as a cross-repository class in wrightkit/.github#110.