Skip to content

fix(host): pin the KWin Wayland socket at host startup - #79

Merged
vindeckyy merged 1 commit into
mainfrom
fix/kwin-socket-pin-reviewed
Nov 16, 2026
Merged

vindeckyy merged 1 commit into
mainfrom
fix/kwin-socket-pin-reviewed

Conversation

@vindeckyy

@vindeckyy vindeckyy commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Supersedes #76. Same change by KooshaPari, with the review fixes applied directly since I cannot push to the fork.

Fixes applied on top of #76:

  • cargo fmt clean (the two diffs that were failing CI)
  • connect_kwin now honors WAYLAND_SOCKET precedence, matching connect_wayland_diagnostic, so probing and virtual-output creation cannot target different compositors
  • removed the dead Linux-gated warm_socket call in the Windows-only run_default_serve
  • kwin module is pub(crate), not pub; only warm_socket is re-exported
  • output management (Session::open) routes through the pinned connect, so display configuration survives WAYLAND_DISPLAY being cleared, not just capture
  • pin resolution extracted into a pure resolve_pinned_socket helper with unit tests, plus a note that the OnceLock init must run after warm_socket since it reads the env without ENV_LOCK

Verified locally: fmt clean, ss-vdisplay 139 passed, slipstream-host 397 passed with the same 4 pre-existing slipstream1 environment failures as unmodified main.


Devin Review

Takes over PR #76 with the review fixes applied: fmt, WAYLAND_SOCKET
precedence in connect_kwin, dead code removal, kwin module visibility,
output management routed through the pinned connect, and unit tests for
the pin resolution.
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fc3d3a84-2cf0-47cb-98ec-a770c82355ef
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Devin Review: 1 flag

Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)

Devin Review

@vindeckyy
vindeckyy merged commit 8f2ce97 into main Nov 16, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants