Skip to content

feat(macos-client): HostAdvert and ConnectOutcome seams - #80

Merged
vindeckyy merged 2 commits into
mainfrom
feat/macos-client-seams-reviewed
Nov 16, 2026
Merged

vindeckyy merged 2 commits into
mainfrom
feat/macos-client-seams-reviewed

Conversation

@vindeckyy

@vindeckyy vindeckyy commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Supersedes #78. Same macOS-client seams change by KooshaPari, rebased onto main after #79, with the review fixes applied directly since I cannot push to the fork.

The KWin socket pin that rode along in #78 is now in main via #79, so this PR is only the macOS seams commit plus one fixup:

  • trim the pair TXT value before matching (mirrors the fingerprint trimming directly above it), with a test

What I did not do: the fmt fixes, dead code removal, and pub(crate) change from the #78 review are all in #79 already. There is still no macOS/Swift CI job, so the Swift half is verified only by the author's local run; adding that job is a separate piece of work.

Verified locally: fmt clean. Swift cannot be compiled on this host, so the Swift tests are author-verified only.


Devin Review

KooshaPari and others added 2 commits November 16, 2026 12:58
Mirrors the fingerprint trimming directly above it: a whitespace-padded
pair value must decode the same as the bare value, not fall through to
unspecified.
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e5cb4cc5-1c78-4794-8cb0-d38e65eeb9f9
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@vindeckyy
vindeckyy merged commit 9627d39 into main Nov 16, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants