Repository navigation
feat: Lut colour grade on Clip and Timeline - #108
Closed
ankit-v2-3 wants to merge 2 commits into
Closed
ankit-v2-3 wants to merge 2 commits into
ankit-v2-3 wants to merge 2 commits into
Conversation
Adds Lut(src, intensity) for 3D .cube lookup tables. Clip(lut=...) grades one clip before its filter; Timeline.lut grades the whole composited frame under captions. Lut.from_file uploads a local .cube through the collection upload URL, the same path large timelines use. The field is emitted only when set, so existing timelines serialize unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Adds Motion(enter, exit, keyframes) with MotionPreset (fade, slides, pop, wipes; duration, amount, easing) and Keyframe (time, value, easing) on offset.x/y, scale, rotation and opacity, plus the Effect enum for the server's named effect set. Clip(motion=...) is emitted only when set, so existing timelines serialize unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
1 of 2 tasks
1 of 2 tasks
Collaborator
Author
|
Superseded by #110: the branch was renamed to |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 3D
.cubeLUT colour grading to the editor, matching the server-side contract in Spext/streaming_service#75 and Spext/videodb-server#1052.Lut(src, intensity=1.0):srcis the URL of a.cubefile;intensityblends from untouched (0) to fully graded (1).Lut.from_file(connection, path, intensity)uploads a local.cubethrough the collection upload URL (the sameupload_bytespath large timelines use) and returns aLutpointing at it. The server rewrites that upload URL to a readable one before compile.Clip(lut=...)grades one clip, applied before itsfilter. Not valid on audio or caption clips (the server rejects it).Timeline.lutgrades the whole composited frame, under any captions.filter, so existing timelines serialize exactly as before. Older servers ignore the field silently, so deploy the service first.Test plan
pytest— 11 passed (6 new intests/test_editor_lut.py: serialization, intensity bounds, emit-only-when-set on Clip and Timeline,from_fileupload call and error wrapping)generate_stream()on a timeline with a clip LUT and a timeline LUT, confirm the graded stream plays🤖 Generated with Claude Code