Repository navigation
feat: Motion presets, keyframes and Effect names on Clip - #109
Merged
Merged
Conversation
Adds Motion(enter, exit, keyframes) with MotionPreset (fade, slides, pop, wipes; duration, amount, easing) and Keyframe (time, value, easing) on offset.x/y, scale, rotation and opacity, plus the Effect enum for the server's named effect set. Clip(motion=...) is emitted only when set, so existing timelines serialize unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
1 of 2 tasks
Collaborator
Author
|
Folded into #110 (single SDK PR for LUT + motion, base |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #108 (LUT). Base will move to
mainautomatically when #108 merges. Server side: Spext/streaming_service#76 (videodb-server needs no change, the timeline dict passes through).Motion(enter=None, exit=None, keyframes=None)→Clip(motion=...). Emitted only when set.MotionPreset(preset, duration=0.4, amount=0.08, easing=ease_out)withMotionPresetName:fade,slide_up/down/left/right,pop,wipe_left/right. Slides and pop include a fade; an exit runs the entrance backwards.Keyframe(time, value, easing=linear)onKeyframeProperty:offset.x,offset.y,scale,rotation(degrees, clockwise),opacity. Clip-relative times, easing on the destination keyframe, values replace the base and hold outside their range.Easing:linear,ease_in,ease_out,ease_in_out,back_out.Effectenum for the server's defined set:zoom_in,shake,zoom_out,ken_burns,pulse.Clip.effectstill accepts a plain string.effect, exclusive with a transition side, fits the clip, 32 keyframes max) are enforced by the service with a public error.Docstring notes the text-layer caveat: text is drawn on a canvas-sized layer, so
scale/rotationact about the canvas centre unlessTextAsset.width/heightis set.Test plan
pytest— 22 passed (11 new intests/test_editor_motion.py)generate_stream()with a slide_up/fade text clip, a keyframed logo and aken_burnsclip🤖 Generated with Claude Code