Repository navigation
Replace the Ember array extensions with native arrays in the classic hyper-table - #294
Merged
Merged
Conversation
…e array extensions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The classic hyper-table relied on the Ember array prototype extensions (
findBy,filterBy,mapBy,sortBy,setEach,pushObject,removeObject,firstObject) that apps enable and Ember 6 removes. Receivers here are native arrays (table state, filters, facets), A() arrays, or Data collections, so all sites use native array methods plusget/setwhere a record may be a proxy. Mutations (columns,editStatus,predefinedViews) now replace the array throughset, so templates and dependent keys keep updating;firstObjectinlistand the search computed becomesfirstItem/_firstColumn. v2manage-columnsdropsA().sortByfor a sort withcompare. Inindex.jsthefields.sortBy('name')whose result was discarded is removed.Tests were added first, running with the extensions emulated on the old code, then run on the new code without them (new suite 336 tests). Table
updateDataand the classic table could not run on the dummy app (extensions disabled) before this change.Base: #293 (
pn/cd-375-action-helper). Part of CD-376, M2 wave 3.