Repository navigation
Conversation
Mechanical: `constructor(owner: unknown, ...)` becomes `constructor(owner: Owner, ...)` in 10 files. @glimmer/component 2 requires a typed owner and the change also compiles against 1.x.
ember-intl 7 requires the locale in setupIntl and no longer sets this.intl on the test context; 6.x accepts both forms.
…er-intl 7, glimmer 2 oss-components is pinned to its Ember 7 branch, @ember/test-waiters is overridden to 4.x and the oss-components peer range, which the new major would reject, is dropped.
pnpm ignored the workspace overrides (the test-waiters one included) while package.json carried resolutions. ember-flatpickr 3.2.3 compiles with ember-cli-htmlbars 6, which cannot load the template compiler on Ember 7, so it is overridden to 7 as well.
They rendered format-number without a locale, which ember-intl 7 no longer defaults.
The v1 builds (ember-flatpickr 3.2.3, ember-sortable 4.0.3) cannot build on Ember 7: they need ember-auto-import to import @ember/test-waiters and @glimmer/component, and flatpickr 3 ships its own @glimmer/component 1 and ember-cli-htmlbars 6. The v2 releases keep the same components and modifiers; flatpickr 4 is now a direct dependency because 9 takes it as a peer.
phndiaye
requested review from
Elodie-DeMatteis-Upf,
OwenCoogan and
edouardmisset
and removed request for
a team
November 3, 2026 14:07
phndiaye
marked this pull request as draft
November 3, 2026 15:05
Member
Author
|
Parked: Ember 7 is on hold until third-party patches are resolved; branch kept, will be rebased when we resume |
Member
Author
|
Closed: the Ember 7 trial is dropped; we stay on Ember 6.12. Branch kept for reference, not deleted. The 6.12-safe parts were re-landed separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ember 7.3.1 / ember-cli ~7.3.0, classic loose build kept (dummy app only). Stacked on #293 (
pn/cd-375-action-helper, which contains the 6.12 bump #294/#295 and #296); retarget tofeature/ember-upgrade-4-to-7once #293 merges. Review commit by commit.Ownertypes:constructor(owner: unknown, ...)toOwnerin 10 files (mechanical).setupIntl(hooks)tosetupIntl(hooks, 'en-us')(11 files),this.intllooked up where read,setupIntladded to the 2 files that used the service without it,TestContextimported from@ember/test-helpers(ember-intl 7 no longer exports it). Kept in this PR (about 25 files, ~40 lines) rather than split.ember-cli-htmlbars^7.0.1,use-ember-modules(@ember/optional-features^3),babel-plugin-ember-template-compilation^3.1.0,ember-intl^7.5.0,@glimmer/component^2.2.1,@ember/test-waiters^4.1.2 override, oss-components pinned topn/cd-383-ember-7-3.engines.node>= 20.19.resolutionsmoved intopnpm-workspace.yamloverrides: withresolutionspresent pnpm ignored the workspace overrides, so the test-waiters override was not applied (the commit message also mentions a short-lived ember-flatpickr override, replaced by item 7).hyper-table-test, numeric renderer), which renderedformat-numberwithout a locale.ember-flatpickr^3.1.1 to ^9.0.2 (+flatpickr^4.6.13 as a direct dependency, a peer of 9) andember-sortable^4.0.3 to ^5.4.1: the v1 builds fail on Ember 7 ("needs to depend on ember-auto-import", and flatpickr 3 pulls its own @glimmer/component 1 and htmlbars 6). SameEmberFlatpickrcomponent and sortable helpers/modifiers; the date filter and column reordering tests pass. ember-flatpickr 9 declares node >= 22 in engines (warning only). Not visually checked.Pin: oss-components 89f18b66 =
git ls-remoteofpn/cd-383-ember-7-3today (merge oss-components#732 first, then retarget).ember-cli-ifais resolved but not loaded by the dummy app, so no patch here.Checks on the head: frozen install, tsc 0, production build,
ember ts:precompile, tests 335 pass / 1 skipped (same as the 6.12 baseline), Chrome. Known open items #288, #291 and template lint untouched; lint:js not run (eslint does not start here).pnpm why: ember-cli-htmlbars 7.0.1 only; @embroider/shared-internals 2.8.1/3.2.1.Peer ranges (hyperevents ^1.x, oss-components ^3.x) are left as they were; the last commit restores them after an earlier commit in this PR had dropped them.
🤖 Generated with Claude Code