Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/hash/hash.c
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ static void php_hash_do_hash(
}
if (isfilename) {
if (zend_char_has_nul_byte(data, data_len)) {
zend_argument_value_error(1, "must not contain any null bytes");
zend_argument_value_error(2, "must not contain any null bytes");
RETURN_THROWS();
}
stream = php_stream_open_wrapper_ex(data, "rb", REPORT_ERRORS, NULL, FG(default_context));
Expand Down
10 changes: 10 additions & 0 deletions ext/hash/tests/hash_file_error.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,13 @@ try {
echo $exception::class, ': ', $exception->getMessage(), "\n";
}

echo "\n-- Testing hash_file() function with a null byte in the filename --\n";
try {
hash_file('md5', $filename . chr(0) . $filename);
} catch (Throwable $e) {
echo $e::class, ': ', $e->getMessage(), "\n";
}

echo "\n-- Testing hash_file() function with a non-existent file --\n";
var_dump(hash_file('md5', 'nonexistent.txt'));

Expand All @@ -36,6 +43,9 @@ unlink( $filename );
-- Testing hash_file() function with an unknown algorithm --
ValueError: hash_file(): Argument #1 ($algo) must be a valid hashing algorithm

-- Testing hash_file() function with a null byte in the filename --
ValueError: hash_file(): Argument #2 ($filename) must not contain any null bytes

-- Testing hash_file() function with a non-existent file --

Warning: hash_file(): Failed to open stream: No such file or directory in %s on line %d
Expand Down
2 changes: 1 addition & 1 deletion ext/pcntl/pcntl.stub.php
Original file line number Diff line number Diff line change
Expand Up @@ -1023,7 +1023,7 @@ function pcntl_waitid(int $idtype = P_ALL, ?int $id = null, &$info = [], int $fl
function pcntl_wait(&$status, int $flags = 0, &$resource_usage = []): int {}

/** @param callable|int $handler */
function pcntl_signal(int $signal, $handler, bool $restart_syscalls = true): bool {}
function pcntl_signal(int $signal, $handler, ?bool $restart_syscalls = null): bool {}

/** @return callable|int */
function pcntl_signal_get_handler(int $signal) {}
Expand Down
4 changes: 2 additions & 2 deletions ext/pcntl/pcntl_arginfo.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions ext/pcntl/pcntl_decl.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 36 additions & 0 deletions ext/pcntl/tests/pcntl_signal_restart_syscalls.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
--TEST--
pcntl_signal(): $restart_syscalls is nullable
--EXTENSIONS--
pcntl
--FILE--
<?php
declare(strict_types=1);

$parameter = (new ReflectionFunction('pcntl_signal'))->getParameters()[2];
var_dump((string) $parameter->getType());
var_dump($parameter->allowsNull());
var_dump($parameter->getDefaultValue());

var_dump(pcntl_signal(SIGALRM, SIG_IGN));
var_dump(pcntl_signal(SIGALRM, SIG_IGN, null));
var_dump(pcntl_signal(SIGALRM, SIG_IGN, true));
var_dump(pcntl_signal(SIGALRM, SIG_IGN, false));

try {
pcntl_signal(SIGALRM, SIG_IGN, 1);
} catch (Throwable $e) {
echo $e::class, ': ', $e->getMessage(), "\n";
}

var_dump(pcntl_signal(SIGALRM, SIG_DFL));
?>
--EXPECT--
string(5) "?bool"
bool(true)
NULL
bool(true)
bool(true)
bool(true)
bool(true)
TypeError: pcntl_signal(): Argument #3 ($restart_syscalls) must be of type ?bool, int given
bool(true)