[pull] master from php:master - #1237
Merged
Merged
Conversation
…23531) pcntl_signal() parses its third argument with Z_PARAM_BOOL_OR_NULL(), so null is accepted, and null is also what selects the SIGALRM specific default of false. The stub declared a non-nullable bool defaulting to true, so Reflection reported a signature the implementation does not honour. Co-authored-by: NickSdot <32384907+NickSdot@users.noreply.github.com>
#23534) php_hash_do_hash() hardcodes argument index 1 in the isfilename branch, so hash_file() blames $algo for a null byte carried by $filename. hash_file() is the only caller passing isfilename = 1, and its filename is argument #2; php_hash_do_hash_hmac() already uses 2 for the same check. Co-authored-by: NickSdot <32384907+NickSdot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )