Skip to content

Add opt-in workflow task chunking shutoff - #1659

Open
eamsden wants to merge 11 commits into
mainfrom
eamsden/disable-workflow-task-chunking
Open

eamsden wants to merge 11 commits into
mainfrom
eamsden/disable-workflow-task-chunking

Conversation

@eamsden

@eamsden eamsden commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

What was changed

Add default-off chunking shutoff in Core and the C bridge. SDK flag 5 records a safe transition for new workflows.

Why?

The current chunker is complex, brittle, and has already introduced non-determinism. By not chunking we can preserve task boundaries and workflow clocks during replay.

Batching of language activations is intended to be released together with this change but will be PRed separately.

Checklist

  1. Closes: N/A.
  2. How was this tested: Core tests with the feature on/off, 15 C-bridge tests, formatting, and both lint checks.
  3. Any docs updates needed? Updated the Core README, activation contract, chunking design, and changelog.

@Sushisource
Sushisource force-pushed the eamsden/disable-workflow-task-chunking branch from c21c092 to b8f2f8a Compare November 16, 2026 20:41
@Sushisource
Sushisource marked this pull request as ready for review November 16, 2026 23:26
@Sushisource
Sushisource requested a review from a team as a code owner November 16, 2026 23:26
@Sushisource
Sushisource force-pushed the eamsden/disable-workflow-task-chunking branch from 1df2d53 to 1499311 Compare November 16, 2026 23:26
&& self.get_machine_key(CommandID::LocalActivity(seq)).is_ok()
{
self.local_activity_data
.advance_to_next_resolution_activation();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A heads-up from the Streams stack (#1801), which sits on this PR now.

It adds a second kind of held result, a page of a Stream read. Its marker has an activation index, like a Local Activity result. When a task holds both and has no other job, this step advances to the next Local Activity index only.

Is it worth making the step take the lowest held index of any kind, e.g. through one shared "next held activation" value? Otherwise, I'll handle it in #1801 by taking the smaller of the two indexes here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your proposal makes sense, but, we might as well do it in your PR still, since that should be a backwards-compatible addition.

Consume workflow task history without shifting the remaining events and move owned replay history into the synthetic poll response. Apply validated workflow commands directly on the workflow processing thread.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants