Repository navigation
Conversation
Sushisource
force-pushed
the
eamsden/disable-workflow-task-chunking
branch
from
November 5, 2026 01:53
feb7386 to
575fbb7
Compare
Sushisource
force-pushed
the
eamsden/disable-workflow-task-chunking
branch
from
November 16, 2026 20:41
c21c092 to
b8f2f8a
Compare
Sushisource
marked this pull request as ready for review
November 16, 2026 23:26
Sushisource
force-pushed
the
eamsden/disable-workflow-task-chunking
branch
from
November 16, 2026 23:26
1df2d53 to
1499311
Compare
moetemp
reviewed
Nov 17, 2026
| && self.get_machine_key(CommandID::LocalActivity(seq)).is_ok() | ||
| { | ||
| self.local_activity_data | ||
| .advance_to_next_resolution_activation(); |
Contributor
There was a problem hiding this comment.
A heads-up from the Streams stack (#1801), which sits on this PR now.
It adds a second kind of held result, a page of a Stream read. Its marker has an activation index, like a Local Activity result. When a task holds both and has no other job, this step advances to the next Local Activity index only.
Is it worth making the step take the lowest held index of any kind, e.g. through one shared "next held activation" value? Otherwise, I'll handle it in #1801 by taking the smaller of the two indexes here.
Member
There was a problem hiding this comment.
I think your proposal makes sense, but, we might as well do it in your PR still, since that should be a backwards-compatible addition.
Consume workflow task history without shifting the remaining events and move owned replay history into the synthetic poll response. Apply validated workflow commands directly on the workflow processing thread.
…low-task-chunking
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Add default-off chunking shutoff in Core and the C bridge. SDK flag 5 records a safe transition for new workflows.
Why?
The current chunker is complex, brittle, and has already introduced non-determinism. By not chunking we can preserve task boundaries and workflow clocks during replay.
Batching of language activations is intended to be released together with this change but will be PRed separately.
Checklist