Repository navigation
Conversation
eamsden
force-pushed
the
eamsden/workflow-activation-batches
branch
from
October 16, 2026 00:03
7525bb3 to
c94e9a7
Compare
Process batches sequentially per workflow run and return indexed completion prefixes according to Core's continuation policy. Include the native SDK replay regression test and Rust SDK changelog entry.
Sushisource
force-pushed
the
eamsden/workflow-activation-batches
branch
from
November 17, 2026 00:24
c94e9a7 to
e2984fc
Compare
Member
|
I am closing this because I don't think the complexity is worth it. There is only one remaining pathological case where un-chunked can cause significant increase in replay time: When history consists of many many sections in a row that look specifically like: Note that, importantly, the signal has to be after scheduled but before started which is highly unusual in the real world. The only other situation would be a sequence of totally empty tasks, as in LA heartbeating, but the un-chunking PR deals with this by simply not waking on empty activations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Require activation batches and indexed completion batches across Core, the Rust SDK, and the C bridge. Core supplies the continuation policy and batches replay from available history, retaining singleton batches where needed.
Stacked on #1659 at
149931194. Rebased to preserve workflow-start-only chunking selection and internal handling of jobless tasks.Why?
Reduce Core/language round trips while preserving activation boundaries, replay checks, and history recording. Batching applies independently of chunking.
Checklist
cargo lint,cargo test-lint, andcargo changelog-check. The existing port-binding unit test failed with AddrInUse; unit suites passed with that test excluded. Full integration suites were not run.