Skip to content

Ungate CAP_0084_MUXED_CONTRACT and CAP_0087_ML_DSA ifdefs - #321

Merged
anupsdf merged 1 commit into
mainfrom
ungate-cap-0084-0087
Oct 7, 2026
Merged

anupsdf merged 1 commit into
mainfrom
ungate-cap-0084-0087

Conversation

@sisuresh

@sisuresh sisuresh commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Removes the remaining protocol 30 gates (CAP_0084_MUXED_CONTRACT, CAP_0087_ML_DSA) so both CAPs' XDR lands in curr, following #311 and #320. TEST_FEATURE is untouched.

First of the P30 ungating stack: this → rs-stellar-xdr regen → rs-soroban-env repin → stellar-core#5478.

https://claude.ai/code/session_01MUfDZLWtSNdpoFYK9XVeHs

Remove the remaining protocol 30 preprocessor gating so CAP-0084's muxed
contract address and CAP-0087's ML-DSA cost types are unconditionally present
on main, and therefore land in curr as well as next. Folds the gated leading
commas in the SCAddressType and ContractCostType enums back onto the
preceding line.

Claude-Session: https://claude.ai/code/session_01MUfDZLWtSNdpoFYK9XVeHs

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review issues were identified.

Review effort: Lite
Findings: None

What changed in this PR

Ungates protocol 30 XDR definitions for muxed contracts and ML-DSA in curr.

Changes:

  • Makes muxed-contract address types unconditional.
  • Makes ML-DSA contract cost types unconditional.
  • Preserves TEST_FEATURE.
File Description
Stellar-contract.x Ungates muxed-contract XDR definitions.
Stellar-contract-config-setting.x Ungates ML-DSA cost types.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@sisuresh
sisuresh requested a review from anupsdf October 7, 2026 15:44
@anupsdf
anupsdf merged commit 4f524bb into main Oct 7, 2026
9 checks passed
@anupsdf
anupsdf deleted the ungate-cap-0084-0087 branch October 7, 2026 16:12
sisuresh added a commit to stellar/rs-stellar-xdr that referenced this pull request Oct 7, 2026
sisuresh added a commit to sisuresh/rs-soroban-env that referenced this pull request Oct 7, 2026
sisuresh added a commit to sisuresh/stellar-core that referenced this pull request Oct 7, 2026
stellar/stellar-xdr#321 (4f524bb), stellar/rs-soroban-env#1745 (ca1e609) and
stellar/stellar-quorum-analyzer#28 (811d19a), all on rs-stellar-xdr#606
(28f34cf). Same trees as the PR heads, so golden data is unchanged.

Claude-Session: https://claude.ai/code/session_01MUfDZLWtSNdpoFYK9XVeHs
sisuresh added a commit to sisuresh/stellar-core that referenced this pull request Oct 8, 2026
Bumps CURRENT_LEDGER_PROTOCOL_VERSION to 30 (adding V_31 for vnext) and
promotes the p30 host to current: built unconditionally, soroban_curr, and
given --features=next in vnext builds so it reports 31 (routed to p30_cache).
fastdev keeps only the two latest hosts, now p29 and p30.

Ungates CAP-0084 and CAP-0087: removes the CAP_0084_MUXED_CONTRACT and
CAP_0087_ML_DSA ifdefs and their configure.ac / common.mk / Makefile.am /
cppFeatures wiring, and creates the ML-DSA cost types 86-94 at the v30
upgrade. Pins XDR to stellar/stellar-xdr#321, the p30 host to
stellar/rs-soroban-env#1745 and the quorum analyzer to
stellar/stellar-quorum-analyzer#28, all on stellar/rs-stellar-xdr#606, so
checkXDRFileIdentity passes.

Claude-Session: https://claude.ai/code/session_01MUfDZLWtSNdpoFYK9XVeHs
sisuresh added a commit to sisuresh/stellar-core that referenced this pull request Oct 8, 2026
Bumps CURRENT_LEDGER_PROTOCOL_VERSION to 30 (adding V_31 for vnext) and
promotes the p30 host to current: built unconditionally, soroban_curr, and
given --features=next in vnext builds so it reports 31 (routed to p30_cache).
fastdev keeps only the two latest hosts, now p29 and p30.

Ungates CAP-0084 and CAP-0087: removes the CAP_0084_MUXED_CONTRACT and
CAP_0087_ML_DSA ifdefs and their configure.ac / common.mk / Makefile.am /
cppFeatures wiring, and creates the ML-DSA cost types 86-94 at the v30
upgrade. Pins XDR to stellar/stellar-xdr#321, the p30 host to
rs-soroban-env main (8abed90, after stellar#1745/stellar#1746) and the quorum analyzer to
stellar/stellar-quorum-analyzer#28, all on stellar/rs-stellar-xdr#606, so
checkXDRFileIdentity passes.

Claude-Session: https://claude.ai/code/session_01MUfDZLWtSNdpoFYK9XVeHs
SirTyson pushed a commit to SirTyson/stellar-core that referenced this pull request Oct 9, 2026
Bumps `CURRENT_LEDGER_PROTOCOL_VERSION` to 30 and promotes the p30 host
to current (vnext builds it with `next`, reporting 31). Ungates CAP-0084
and CAP-0087 in core: merges in stellar#5455 (CAP-0087 cost
types/upgrade/tests), removes the `CAP_0084_MUXED_CONTRACT` /
`CAP_0087_ML_DSA` ifdefs and build wiring, and re-enables
`checkXDRFileIdentity`. Baselines, LCM goldens and protocol 30/31 LCM
reference files re-recorded.

Pins (all merged): XDR stellar/stellar-xdr#321, p30 host
stellar/rs-soroban-env#1745, quorum analyzer
stellar/stellar-quorum-analyzer#28, all on stellar/rs-stellar-xdr#606.

https://claude.ai/code/session_01MUfDZLWtSNdpoFYK9XVeHs
gtrepta pushed a commit to runtimeverification/rs-soroban-env that referenced this pull request Oct 19, 2026
Repins `stellar-xdr` to stellar/rs-stellar-xdr#606 (merged as
`28f34cf`), which ungates CAP-0084 and CAP-0087 (and carries the
already-ungated MS close time XDR), and drops the
`cap_0084_muxed_contract` / `cap_0087_ml_dsa` features. No host code
changes; `soroban-env-host` tests pass with and without `next`.

P30 ungating stack: stellar/stellar-xdr#321 → stellar/rs-stellar-xdr#606
→ this → stellar/stellar-core#5478.

https://claude.ai/code/session_01MUfDZLWtSNdpoFYK9XVeHs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants