Repository navigation
Ungate CAP_0084_MUXED_CONTRACT and CAP_0087_ML_DSA ifdefs - #321
Merged
Merged
Conversation
Remove the remaining protocol 30 preprocessor gating so CAP-0084's muxed contract address and CAP-0087's ML-DSA cost types are unconditionally present on main, and therefore land in curr as well as next. Folds the gated leading commas in the SCAddressType and ContractCostType enums back onto the preceding line. Claude-Session: https://claude.ai/code/session_01MUfDZLWtSNdpoFYK9XVeHs
This was referenced Oct 7, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Ungates protocol 30 XDR definitions for muxed contracts and ML-DSA in curr.
Changes:
- Makes muxed-contract address types unconditional.
- Makes ML-DSA contract cost types unconditional.
- Preserves
TEST_FEATURE.
| File | Description |
|---|---|
Stellar-contract.x |
Ungates muxed-contract XDR definitions. |
Stellar-contract-config-setting.x |
Ungates ML-DSA cost types. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
leighmcculloch
approved these changes
Oct 7, 2026
anupsdf
approved these changes
Oct 7, 2026
sisuresh
added a commit
to stellar/rs-stellar-xdr
that referenced
this pull request
Oct 7, 2026
Same tree as 0f59cf2, so the generated code is unchanged. Claude-Session: https://claude.ai/code/session_01MUfDZLWtSNdpoFYK9XVeHs
sisuresh
added a commit
to sisuresh/rs-soroban-env
that referenced
this pull request
Oct 7, 2026
…f34cf) Same tree as 4cf1cef plus the xdr re-pin to stellar/stellar-xdr#321's merge commit. Claude-Session: https://claude.ai/code/session_01MUfDZLWtSNdpoFYK9XVeHs
sisuresh
added a commit
to sisuresh/stellar-core
that referenced
this pull request
Oct 7, 2026
stellar/stellar-xdr#321 (4f524bb), stellar/rs-soroban-env#1745 (ca1e609) and stellar/stellar-quorum-analyzer#28 (811d19a), all on rs-stellar-xdr#606 (28f34cf). Same trees as the PR heads, so golden data is unchanged. Claude-Session: https://claude.ai/code/session_01MUfDZLWtSNdpoFYK9XVeHs
sisuresh
added a commit
to sisuresh/stellar-core
that referenced
this pull request
Oct 8, 2026
Bumps CURRENT_LEDGER_PROTOCOL_VERSION to 30 (adding V_31 for vnext) and promotes the p30 host to current: built unconditionally, soroban_curr, and given --features=next in vnext builds so it reports 31 (routed to p30_cache). fastdev keeps only the two latest hosts, now p29 and p30. Ungates CAP-0084 and CAP-0087: removes the CAP_0084_MUXED_CONTRACT and CAP_0087_ML_DSA ifdefs and their configure.ac / common.mk / Makefile.am / cppFeatures wiring, and creates the ML-DSA cost types 86-94 at the v30 upgrade. Pins XDR to stellar/stellar-xdr#321, the p30 host to stellar/rs-soroban-env#1745 and the quorum analyzer to stellar/stellar-quorum-analyzer#28, all on stellar/rs-stellar-xdr#606, so checkXDRFileIdentity passes. Claude-Session: https://claude.ai/code/session_01MUfDZLWtSNdpoFYK9XVeHs
sisuresh
added a commit
to sisuresh/stellar-core
that referenced
this pull request
Oct 8, 2026
Bumps CURRENT_LEDGER_PROTOCOL_VERSION to 30 (adding V_31 for vnext) and promotes the p30 host to current: built unconditionally, soroban_curr, and given --features=next in vnext builds so it reports 31 (routed to p30_cache). fastdev keeps only the two latest hosts, now p29 and p30. Ungates CAP-0084 and CAP-0087: removes the CAP_0084_MUXED_CONTRACT and CAP_0087_ML_DSA ifdefs and their configure.ac / common.mk / Makefile.am / cppFeatures wiring, and creates the ML-DSA cost types 86-94 at the v30 upgrade. Pins XDR to stellar/stellar-xdr#321, the p30 host to rs-soroban-env main (8abed90, after stellar#1745/stellar#1746) and the quorum analyzer to stellar/stellar-quorum-analyzer#28, all on stellar/rs-stellar-xdr#606, so checkXDRFileIdentity passes. Claude-Session: https://claude.ai/code/session_01MUfDZLWtSNdpoFYK9XVeHs
SirTyson
pushed a commit
to SirTyson/stellar-core
that referenced
this pull request
Oct 9, 2026
Bumps `CURRENT_LEDGER_PROTOCOL_VERSION` to 30 and promotes the p30 host to current (vnext builds it with `next`, reporting 31). Ungates CAP-0084 and CAP-0087 in core: merges in stellar#5455 (CAP-0087 cost types/upgrade/tests), removes the `CAP_0084_MUXED_CONTRACT` / `CAP_0087_ML_DSA` ifdefs and build wiring, and re-enables `checkXDRFileIdentity`. Baselines, LCM goldens and protocol 30/31 LCM reference files re-recorded. Pins (all merged): XDR stellar/stellar-xdr#321, p30 host stellar/rs-soroban-env#1745, quorum analyzer stellar/stellar-quorum-analyzer#28, all on stellar/rs-stellar-xdr#606. https://claude.ai/code/session_01MUfDZLWtSNdpoFYK9XVeHs
gtrepta
pushed a commit
to runtimeverification/rs-soroban-env
that referenced
this pull request
Oct 19, 2026
Repins `stellar-xdr` to stellar/rs-stellar-xdr#606 (merged as `28f34cf`), which ungates CAP-0084 and CAP-0087 (and carries the already-ungated MS close time XDR), and drops the `cap_0084_muxed_contract` / `cap_0087_ml_dsa` features. No host code changes; `soroban-env-host` tests pass with and without `next`. P30 ungating stack: stellar/stellar-xdr#321 → stellar/rs-stellar-xdr#606 → this → stellar/stellar-core#5478. https://claude.ai/code/session_01MUfDZLWtSNdpoFYK9XVeHs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the remaining protocol 30 gates (
CAP_0084_MUXED_CONTRACT,CAP_0087_ML_DSA) so both CAPs' XDR lands in curr, following #311 and #320.TEST_FEATUREis untouched.First of the P30 ungating stack: this → rs-stellar-xdr regen → rs-soroban-env repin → stellar-core#5478.
https://claude.ai/code/session_01MUfDZLWtSNdpoFYK9XVeHs