Skip to content

Bump to protocol 30 and ungate CAP-0084 and CAP-0087 - #5478

Merged
sisuresh merged 3 commits into
stellar:masterfrom
sisuresh:protocol-30
Oct 9, 2026
Merged

sisuresh merged 3 commits into
stellar:masterfrom
sisuresh:protocol-30

Conversation

@sisuresh

@sisuresh sisuresh commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Bumps CURRENT_LEDGER_PROTOCOL_VERSION to 30 and promotes the p30 host to current (vnext builds it with next, reporting 31). Ungates CAP-0084 and CAP-0087 in core: merges in #5455 (CAP-0087 cost types/upgrade/tests), removes the CAP_0084_MUXED_CONTRACT / CAP_0087_ML_DSA ifdefs and build wiring, and re-enables checkXDRFileIdentity. Baselines, LCM goldens and protocol 30/31 LCM reference files re-recorded.

Pins (all merged): XDR stellar/stellar-xdr#321, p30 host stellar/rs-soroban-env#1745, quorum analyzer stellar/stellar-quorum-analyzer#28, all on stellar/rs-stellar-xdr#606.

https://claude.ai/code/session_01MUfDZLWtSNdpoFYK9XVeHs

@sisuresh

sisuresh commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

Do not merge: this disables checkXDRFileIdentity in non-vnext builds until CAP-0084 is ungated (stellar-xdr → rs-stellar-xdr → rs-soroban-env → p30 repin), at which point the check should be re-enabled.

@SirTyson SirTyson mentioned this pull request Oct 7, 2026
5 of 6 tasks
@sisuresh sisuresh changed the title Bump to protocol 30 Bump to protocol 30 and ungate CAP-0084 and CAP-0087 Oct 7, 2026
@sisuresh

sisuresh commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

Update: checkXDRFileIdentity is re-enabled and passes — CAP-0084 and CAP-0087 are now ungated against stellar/stellar-xdr#321, stellar/rs-stellar-xdr#606, stellar/rs-soroban-env#1745 and stellar/stellar-quorum-analyzer#28. Still do not merge until those land and the pins move to their merge commits. This now includes #5455.

@sisuresh
sisuresh marked this pull request as ready for review October 7, 2026 21:03
@sisuresh
sisuresh requested review from jayz22 and a balanced review from Copilot October 7, 2026 21:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The CAP-0087 functional KAT test sources promised by the PR are absent, leaving only stale generated baseline entries.

1 open finding
What changed in this PR

Promotes protocol 30 to current and protocol 31 to next, ungating CAP-0084/CAP-0087 and updating Soroban configuration and golden metadata.

Changes:

  • Promotes the p30 Soroban host and removes CAP-0084 build gates.
  • Adds protocol-30 ML-DSA cost parameters and upgrade handling.
  • Re-records current/next transaction metadata and LCM fixtures.
File Description
test-tx-meta-baseline-next/​TxResultsTests.json Adds protocol-31 baseline.
test-tx-meta-baseline-next/​SetOptionsTests.json Adds protocol-31 baseline.
test-tx-meta-baseline-next/​RevokeSponsorshipTests.json Adds protocol-31 baseline.
test-tx-meta-baseline-next/​MergeTests.json Adds protocol-31 baseline.
test-tx-meta-baseline-next/​ManageDataTests.json Adds protocol-31 baseline.
test-tx-meta-baseline-next/​LiquidityPoolDepositTests.json Adds protocol-31 baseline.
test-tx-meta-baseline-next/​InflationTests.json Advances next protocol metadata.
test-tx-meta-baseline-next/​FrozenLedgerKeysTests.json Advances next protocol metadata.
test-tx-meta-baseline-next/​FeeBumpTransactionTests.json Adds protocol-31 baseline.
test-tx-meta-baseline-next/​EventTests.json Adds protocol-31 event baseline.
test-tx-meta-baseline-next/​EndSponsoringFutureReservesTests.json Adds protocol-31 baseline.
test-tx-meta-baseline-next/​CreateAccountTests.json Adds protocol-31 baseline.
test-tx-meta-baseline-next/​ClawbackTests.json Adds protocol-31 baseline.
test-tx-meta-baseline-next/​ClawbackClaimableBalanceTests.json Adds protocol-31 baseline.
test-tx-meta-baseline-next/​BumpSequenceTests.json Adds protocol-31 baseline.
test-tx-meta-baseline-next/​BeginSponsoringFutureReservesTests.json Adds protocol-31 baseline.
test-tx-meta-baseline-current/​TxResultsTests.json Adds protocol-30 baseline.
test-tx-meta-baseline-current/​SetOptionsTests.json Adds protocol-30 baseline.
test-tx-meta-baseline-current/​RevokeSponsorshipTests.json Adds protocol-30 baseline.
test-tx-meta-baseline-current/​MergeTests.json Adds protocol-30 baseline.
test-tx-meta-baseline-current/​ManageDataTests.json Adds protocol-30 baseline.
test-tx-meta-baseline-current/​LiquidityPoolDepositTests.json Adds protocol-30 baseline.
test-tx-meta-baseline-current/​InflationTests.json Advances current protocol metadata.
test-tx-meta-baseline-current/​FrozenLedgerKeysTests.json Advances current protocol metadata.
test-tx-meta-baseline-current/​FeeBumpTransactionTests.json Adds protocol-30 baseline.
test-tx-meta-baseline-current/​EventTests.json Adds protocol-30 event baseline.
test-tx-meta-baseline-current/​EndSponsoringFutureReservesTests.json Adds protocol-30 baseline.
test-tx-meta-baseline-current/​CreateAccountTests.json Adds protocol-30 baseline.
test-tx-meta-baseline-current/​ClawbackTests.json Adds protocol-30 baseline.
test-tx-meta-baseline-current/​ClawbackClaimableBalanceTests.json Adds protocol-30 baseline.
test-tx-meta-baseline-current/​BumpSequenceTests.json Adds protocol-30 baseline.
test-tx-meta-baseline-current/​BeginSponsoringFutureReservesTests.json Adds protocol-30 baseline.
test-lcm-next/​TxResultsTests/​index.json Reindexes protocol-31 LCMs.
test-lcm-next/​TxEnvelopeTests/​index.json Reindexes protocol-31 LCMs.
test-lcm-next/​PathPaymentTests/​index.json Reindexes protocol-31 LCMs.
test-lcm-next/​OfferTests/​index.json Reindexes protocol-31 LCMs.
test-lcm-next/​MergeTests/​index.json Reindexes protocol-31 LCMs.
test-lcm-next/​FrozenLedgerKeysTests/​index.json Advances next LCM protocol.
test-lcm-next/​BeginSponsoringFutureReservesTests/​index.json Reindexes protocol-31 LCMs.
test-lcm-current/​TxResultsTests/​index.json Reindexes protocol-30 LCMs.
test-lcm-current/​TxEnvelopeTests/​index.json Reindexes protocol-30 LCMs.
test-lcm-current/​PathPaymentTests/​index.json Reindexes protocol-30 LCMs.
test-lcm-current/​OfferTests/​index.json Reindexes protocol-30 LCMs.
test-lcm-current/​MergeTests/​index.json Reindexes protocol-30 LCMs.
test-lcm-current/​FrozenLedgerKeysTests/​index.json Advances current LCM protocol.
test-lcm-current/​BeginSponsoringFutureReservesTests/​index.json Reindexes protocol-30 LCMs.
src/​util/​xdrquery/​XDRFieldResolver.h Ungates muxed-contract resolution.
src/​util/​xdrquery/​test/​XDRQueryTests.cpp Ungates muxed-contract test.
src/​util/​XDRCereal.cpp Ungates muxed-contract JSON output.
src/​util/​ProtocolVersion.h Adds protocol 31.
src/​transactions/​test/​SorobanTxTestUtils.h Exposes muxed-contract helper.
src/​transactions/​test/​SorobanTxTestUtils.cpp Ungates muxed-contract utilities.
src/​transactions/​test/​InvokeHostFunctionTests.cpp Adds focused CAP-0084 tests.
src/​testdata/​ledger-close-meta-v2-protocol-30.json Refreshes protocol-30 fixture.
src/​testdata/​ledger-close-meta-v2-protocol-30-soroban.json Refreshes Soroban fixture.
src/​testdata/​ledger-close-meta-enable-classic-events-v2-protocol-30.json Refreshes classic-events fixture.
src/​testdata/​ledger-close-meta-enable-classic-events-v2-protocol-30-soroban.json Refreshes combined fixture.
src/​rust/​src/​soroban_proto_all.rs Promotes p30 host dispatch.
src/​rust/​src/​soroban_module_cache.rs Adds p30/p31 cache routing.
src/​rust/​src/​dep-trees/​p30-expect.txt Updates p30 dependency snapshot.
src/​rust/​Cargo.toml Repins host and analyzer dependencies.
src/​Makefile.am Promotes p30 and removes XDR gate wiring.
src/​main/​main.cpp Removes obsolete XDR feature declaration.
src/​main/​Config.cpp Sets current protocol to 30.
src/​ledger/​NetworkConfig.h Declares v30 cost initialization.
src/​ledger/​NetworkConfig.cpp Adds ML-DSA cost parameters.
src/​ledger/​LedgerHashUtils.h Ungates muxed-contract hashing.
src/​herder/​Upgrades.cpp Applies v30 cost upgrade.
src/​herder/​test/​UpgradesTests.cpp Tests v30 cost upgrade.
configure.ac Removes CAP-0084 conditional.
common.mk Removes CAP-0084 compiler define.

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Comment thread src/rust/Cargo.toml Resolved
@sisuresh
sisuresh requested review from anupsdf and a balanced review from Copilot October 7, 2026 21:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The ML-DSA KAT is missing and vnext XDR identity checking remains disabled.

2 open findings

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Comment thread src/main/main.cpp Resolved
Comment thread src/Makefile.am Resolved
Copilot AI balanced review requested due to automatic review settings October 7, 2026 23:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Fastdev host pruning conflicts with the existing Rust dispatch assertions and will cause that configuration’s test to fail.

3 open findings
Previously missed (1)

In code that hasn't changed since last review

Low severity Use “corresponding” instead of “correspondent”

src/​ledger/​NetworkConfig.h:305

Use “corresponding” here; “correspondent” refers to a person who reports or exchanges letters.

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Comment thread src/rust/src/soroban_proto_all.rs Resolved
anupsdf
anupsdf previously approved these changes Oct 7, 2026
@sisuresh
sisuresh requested a review from graydon October 8, 2026 01:07
Comment thread src/herder/test/UpgradesTests.cpp Resolved
Comment thread src/ledger/NetworkConfig.cpp Resolved
Copilot AI balanced review requested due to automatic review settings October 8, 2026 02:06
@sisuresh
sisuresh enabled auto-merge October 8, 2026 02:07
Copilot AI balanced review requested due to automatic review settings October 8, 2026 05:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The claimed CAP-0087 end-to-end test is missing, and fastdev dispatch test expectations no longer match the configured hosts.

3 open findings

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Comment thread src/rust/src/soroban_module_cache.rs Resolved
Comment thread src/rust/src/soroban_module_cache.rs Resolved
@sisuresh
sisuresh added this pull request to the merge queue Oct 8, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Oct 8, 2026
@anupsdf
anupsdf added this pull request to the merge queue Oct 8, 2026
@sisuresh
sisuresh removed this pull request from the merge queue due to a manual request Oct 8, 2026
@sisuresh
sisuresh added this pull request to the merge queue Oct 8, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Oct 8, 2026
@sisuresh
sisuresh added this pull request to the merge queue Oct 8, 2026
@sisuresh
sisuresh removed this pull request from the merge queue due to a manual request Oct 9, 2026
@sisuresh
sisuresh added this pull request to the merge queue Oct 9, 2026
@sisuresh
sisuresh removed this pull request from the merge queue due to a manual request Oct 9, 2026
@sisuresh
sisuresh added this pull request to the merge queue Oct 9, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 9, 2026
@sisuresh
sisuresh added this pull request to the merge queue Oct 9, 2026
Merged via the queue into stellar:master with commit 4e2c208 Oct 9, 2026
54 of 56 checks passed
@sisuresh
sisuresh deleted the protocol-30 branch October 9, 2026 02:53
tamirms added a commit to sisuresh/stellar-horizon that referenced this pull request Oct 9, 2026
stellar/stellar-core#5478 made protocol 30 the current protocol on master,
with CAP-0084 and CAP-0087. Move the P30 leg from the pre-#5478 vnext build
(88d2431d7) to master's ba6a4e6e3 build, and in the same change give
unlimited-config-v30.xdr the 95 contract cost params core now requires at
protocol 30. The 9 new ML-DSA entries (86-94) are core's v30 defaults from
updateCpuCostParamsEntryForV30 / updateMemCostParamsEntryForV30; the other
entries are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J5dN6jqdJt52ve9XWyeggH
tamirms added a commit to sisuresh/stellar-rpc that referenced this pull request Oct 9, 2026
stellar/stellar-core#5478 made protocol 30 the current protocol on master,
with CAP-0084 and CAP-0087, and its p30 host is rs-soroban-env 8abed902, the
same as soroban-env-host-curr. Move the P30 leg from the pre-#5478 vnext
build (88d2431d7) to master's ba6a4e6e3 build.

In the same change, give testnet.p30 and unlimited.p30 the 95 contract cost
params core now requires at protocol 30. The 9 new ML-DSA entries (86-94)
are core's v30 defaults from updateCpuCostParamsEntryForV30 /
updateMemCostParamsEntryForV30; every other entry is unchanged. The .xdr
files are re-encoded from the .json with stellar-xdr encode --type
ConfigUpgradeSet.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J5dN6jqdJt52ve9XWyeggH
tamirms added a commit to stellar/stellar-rpc that referenced this pull request Oct 15, 2026
* Shift soroban-env window to P30 with CAP-0084 pins

go-stellar-sdk replaced to sisuresh/go @ 50ebbb65; -prev now 28.0.1,
-curr git-pinned to rs-soroban-env#1700 head with next; stellar-xdr
git-pinned with cap_0084_muxed_contract.

* methods: drop EventInfo.InSuccessfulContractCall

Removed from protocols/rpc in the pinned go-stellar-sdk (#5995).

* Repin CAP-0084 host window to merged upstream heads

-prev now tracks core's protocol-29 stand-in (rs-soroban-env cb32250d,
no crates.io release exists for it); -curr moves off the rs-soroban-env
fork PR to its merged commit 169890d5 (protocol 30 by default, no
`next` feature needed). stellar-xdr repinned to a9c9750e to match
curr's own pin. go-stellar-sdk fork pin bumped to the PR #6015 head
(still unmerged upstream).

* ci: add P30 integration leg, copy P28 upgrade fixtures

Drops the oldest P27 leg per the one-stanza-per-protocol convention.
No -vnext core artifact exists yet for CAP-0084, so the P30 leg's core
image is left unset. Upgrade fixtures copied from P28 unchanged since
CAP-0084 doesn't touch ConfigSettings.

* ci: test protocols 29 and 30 against merged stellar-core 73f2bdd1

The host window is now 29/30, so the P28 leg becomes P29 (with p29 upgrade
fixtures copied from p28, as p30's were). Both legs use stellar-core
73f2bdd1's published artifacts. Host blocks declare their versions so
check-dependencies.bash can find them.

* ci: add apt.stellar.org unstable for unreleased core packages

stellar-core 73f2bdd1's packages are only in the unstable component.

* Repin go-stellar-sdk to the go-stellar-sdk#6015 head (663a89a1)

#6015 is now the single P30 SDK PR: XDR regenerated from stellar-xdr
4f524bba with CAP-0084, CAP-0087 and CAP-0088, plus ingest/ledger
NodeID/Signature handling for every signed StellarValue arm. 663a89a1 is
174b61f0 with go-stellar-sdk main (6c5e720f: #6006, #6014, #6017) merged
in, so the replace does not drop fixes RPC would otherwise get from main.

No compile breaks beyond the EventInfo.InSuccessfulContractCall removal
already in this branch: RPC uses storage.ConnectOptions but none of the
cache APIs #6017 removed. go mod tidy drops hashicorp/golang-lru, which
only the removed on-disk cache needed.

The replace stays allow-listed in .golangci.yml until #6015 merges.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Repin the soroban host window to the real P29 host and P30 main

- soroban-env-host/simulation-prev: cb32250d (core's p29 stand-in) ->
  rs-soroban-env v29.0.0 (a721944b), stellar-core's src/rust/soroban/p29
  in v29.0.0 and master, pinned by git so it builds with the same
  dependency tree as core's p29 host.
- soroban-env-host/simulation-curr: 169890d5 (CAP-0084 only) ->
  rs-soroban-env main 8abed902, with CAP-0084 and the CAP-0087 ML-DSA host
  functions ungated (#1737, #1744, #1745, #1746). This is the p30 host
  stellar-core #5478 pins; core master's p30 (fddfd567) predates ML-DSA.
  To be repinned to core's final p30 submodule once core #5455/#5478 merge.
- stellar-xdr: a9c9750e -> 28f34cf5, curr's own pin (XDR from stellar-xdr
  4f524bba, as in the Go SDK). CAP-0084, CAP-0087 and CAP-0088 are ungated
  there, so the cap_0084_muxed_contract feature goes away, and xdr2json
  can now decode CAP-0088 StellarValue arms (MS_CLOSE_TIME was a disabled
  feature at a9c9750e).

The new ml-dsa dependency tree resolves to the versions in core's p30
dep-tree, except hybrid-array 0.4.10 (core: 0.4.15; 0.4.11+ needs
typenum 1.20 and the lockfile has 1.18) and ctutils 0.4.3 (core: 0.4.2).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J5dN6jqdJt52ve9XWyeggH

* methods: test serving CAP-0088 millisecond close time ledgers

Ingests a protocol 30 ledger whose StellarValue uses STELLAR_VALUE_SIGNED_MS
(and, separately, STELLAR_VALUE_EMPTY_TX_SET_MS) through the writers the
ingestion service uses (ledger, transactions, events, fee windows, commit)
and checks what getLatestLedger, getLedgers (XDR and JSON), getTransaction,
getEvents and getFeeStats serve: every close time is the whole-second
closeTime (closeTimeMs / 1000), the XDR is byte-identical, and xdr2json
keeps the arm and closeTimeMs.

RPC never reads StellarValue.ext, lcValueSignature or the node ID, so the
only real requirement is that both XDR stacks decode the new arms. The JSON
check fails on the previous rs-stellar-xdr pin (a9c9750e, MS_CLOSE_TIME
gated off): getLedgers returns "xdr_to_json() failed: couldn't read
LedgerCloseMeta: xdr value invalid".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* ci: run P29 on stellar-core 29.0.0 and P30 on core master's vnext build

- P29: stellar-core 29.0.0 (4eb833373), as on protocol-next. Its p29 host
  is rs-soroban-env v29.0.0 (a721944b), which soroban-env-host-prev now
  pins, instead of master 73f2bdd1 with the cb32250d stand-in.
- P30: vnext build of master 88d2431d7 (merge of v29.0.0 into master),
  whose p30 host is fddfd567: CAP-0084 plus the v29.0.0 fixes. It differs
  from soroban-env-host-curr (8abed902) only by the ML-DSA commits. No core
  build with CAP-0087 (#5455/#5478) or CAP-0088 (#5423) is published yet.

Its deb is only in the apt.stellar.org unstable component, which
integration-tests.yml already adds.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* integrationtest: drop the P28 upgrade fixtures

No CI leg runs protocol 28 any more (P29 and P30 only), and the harness
picks <name>.p<protocol>.xdr for the protocol under test. Following the
docker/README convention of moving the oldest fixtures to the new
protocol, this leaves p29 and p30, which are identical to the old p28 ones.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* scripts: fix check-dependencies for the P29/P30 window and SDK replaces

The dependency sanity check failed on this branch for two reasons that
were not real mismatches:

- It looked up `stellar-xdr@<protocol>`, assuming the crate's major
  version tracks the protocol. The protocol 29 and 30 hosts both use
  stellar-xdr 28.0.0 (crates.io for prev, git 28f34cf5 for curr), so there
  was no match and the Rust XDR revision came out empty. Each host's
  stellar-xdr now comes from that host's own dependency tree, and the
  comparison with core's dep-trees/p<N>-expect.txt uses the host for the
  same protocol rather than always the newest.
- It derived the Go SDK commit from the required go-stellar-sdk version
  and fetched it from stellar/go-stellar-sdk, ignoring the replace
  directive. It now reads xdr/xdr_commit_generated.txt from the module the
  build actually uses (go list -m -f {{.Dir}}), which also handles tags.

On this branch the check now passes: Go (#6015) and the curr host's
rs-stellar-xdr both use stellar-xdr 4f524bba. It still reports, without
failing, that core master's p30 uses rs-stellar-xdr a9c9750e. The updated
script also passes against protocol-next's configuration.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Add Protocol 30 CHANGELOG entries

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* ci: run the P30 leg on stellar-core master after protocol 30 landed

stellar/stellar-core#5478 made protocol 30 the current protocol on master,
with CAP-0084 and CAP-0087, and its p30 host is rs-soroban-env 8abed902, the
same as soroban-env-host-curr. Move the P30 leg from the pre-#5478 vnext
build (88d2431d7) to master's ba6a4e6e3 build.

In the same change, give testnet.p30 and unlimited.p30 the 95 contract cost
params core now requires at protocol 30. The 9 new ML-DSA entries (86-94)
are core's v30 defaults from updateCpuCostParamsEntryForV30 /
updateMemCostParamsEntryForV30; every other entry is unchanged. The .xdr
files are re-encoded from the .json with stellar-xdr encode --type
ConfigUpgradeSet.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J5dN6jqdJt52ve9XWyeggH

* Require the merged go-stellar-sdk Protocol 30 commit

stellar/go-stellar-sdk#6015 merged into protocol-next as 990270d3, so drop the
replace that pointed at the sisuresh/go fork (663a89a1) and require the
upstream commit. This also picks up the fixes made in #6015 after 663a89a1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Run the P30 leg on core 3640, which includes CAP-0088

Build 3640 (0e49751aa) includes stellar/stellar-core#5423, so ledgers after
the protocol 30 upgrade now use the millisecond close-time StellarValue arms.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Run the P30 leg on the stellar-core 30.0.0 release candidate

30.0.0-3642.0e49751aa is built from the same commit as build 3640, so this
changes the package under test, not the code.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Correct how core's p30 host differs from -curr

Core's p30 host also takes stellar-xdr 30.0.0 from crates.io, not only
soroban-wasmi.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Trim comments and the CHANGELOG, drop the CAP-0088 unit test

The P30 integration leg runs on the stellar-core 30.0.0 release candidate,
so its ledgers use the CAP-0088 arms, and the integration tests already
fetch them with getLedgers and getTransaction in JSON.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: tamirms <tamirms@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
gtrepta pushed a commit to runtimeverification/rs-soroban-env that referenced this pull request Oct 19, 2026
Repins `stellar-xdr` to stellar/rs-stellar-xdr#606 (merged as
`28f34cf`), which ungates CAP-0084 and CAP-0087 (and carries the
already-ungated MS close time XDR), and drops the
`cap_0084_muxed_contract` / `cap_0087_ml_dsa` features. No host code
changes; `soroban-env-host` tests pass with and without `next`.

P30 ungating stack: stellar/stellar-xdr#321 → stellar/rs-stellar-xdr#606
→ this → stellar/stellar-core#5478.

https://claude.ai/code/session_01MUfDZLWtSNdpoFYK9XVeHs
SirTyson added a commit to SirTyson/stellar-core that referenced this pull request Nov 9, 2026
Brings overlay-v2-shared up to date with master. The previous master
merge (b90d48e, stellar#5428) was recorded with master's tip 100cc38 missing
from its parents, so this merge used 100cc38 as its base (temporary
graft of b90d48e, removed afterwards).

Notable master changes brought in:
- Protocol 30: CURRENT_LEDGER_PROTOCOL_VERSION follows
  MAX_SUPPORTED_PROTOCOL_VERSION; CAP-0084 and CAP-0087 ungated, p29 and
  p30 Soroban hosts (stellar#5472, stellar#5478, stellar#5484, stellar#5483).
- Millisecond-resolution close times at protocol 30 (stellar#5423):
  ConsensusTime/ApplyTime types, STELLAR_VALUE_SIGNED_MS and
  STELLAR_VALUE_EMPTY_TX_SET_MS.
- Tx set validity hardening (stellar#5481), lower max message size in protocol
  29 (stellar#733), sub-second ledger edge-case fixes.
- Simplified ledger view hierarchy (stellar#5461); the overlay-only-mode
  sequence number skip now lives in TransactionFrame::checkValid.
- Banned accounts deprecated (CAP-0077 is active).
- Apply-path performance work (stellar#5402, stellar#5411, stellar#5414, stellar#5415, stellar#5418, stellar#5421,
  stellar#5436, stellar#5286), apply-load tx set construction mode (stellar#5448), --check-lcm
  (stellar#5435), v29.0.0 release merge.

Conflict resolution:
- Files overlay-v2-shared deleted and master modified (the C++ overlay,
  TransactionQueue, TransactionQueueTests, UpgradesTests, private/Horizon/RPC
  workflows): kept deleted. Master's changes to them are C++ overlay
  peer/flow-control logic, tx queue admission and tests for those.
- Herder: kept the Rust-overlay submission path (recvTransaction returns
  TxSubmitStatus) and dropped the deprecated `force` parameter as master did.
  triggerNextLedger keeps the prepared/built tx set path from the Rust
  mempool, now with ConsensusTime close times and master's apply-time
  close-time offset. The early tx set preparation path (prepareTxSet,
  buildTxSet, setupTriggerNextLedger) takes ConsensusTime. Kept master's
  mNominatedTxSetOverride test hook (applied before the tx set is cached in
  the Rust overlay) and the herder.txset.build timer (now timing
  buildTxSet). Dropped the banned-accounts setup and tx queue maintenance.
- AppConnector: dropped both ov2's maybeUpdateImmutableLedgerView and
  master's C++-overlay getOverlayThreadSnapshot.
- LoadGenerator: master's CachedTestAccountPtr with ov2's TxSubmitStatus.
- Tests: kept ov2's removal of tests that need the C++ overlay, standalone
  mode or the tx queue (standalone, manualclose, flooding, tx queue limits,
  far-future slot cleanup, herderExternalizesValuesWithProtocol, MAX_SAC_TPS,
  custom token, soroswap and noisy binary search apply-load tests). Added
  master's ms close time HerderTests and the non-canonical empty tx set test
  on ov2's Rust-overlay topologies. The tx set size test checks against
  overlay-v2's own tx set allowance. The sub-second
  getUpperBoundCloseTimeOffset test checks the offset directly, since there
  is no C++ tx queue admission. Tests that used CheckValidLedgerViewWrapper
  now use getLCLView().
- Cargo.lock: master's lockfile plus the overlay crate's packages,
  regenerated by cargo; semver-compatible duplicates take the newer
  version.
- Build: Makefile.am keeps the Rust overlay rules and adds tracy
  import-chrome; ci-build.sh keeps ASAN off and takes master's -g1.
- Needed to compile: PendingEnvelopes.cpp includes LedgerManager.h
  (master got it through the C++ OverlayManager.h); ov2's early-nomination
  and checkpoint-slot tests use ConsensusTime/ApplyTimeOffset; OverlayIPC
  tests take ledger views from the LedgerManager.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants