Skip to content

Ungate MS_CLOSE_TIME ifdefs - #320

Merged
SirTyson merged 1 commit into
stellar:mainfrom
SirTyson:ungate-ms-close-time
Oct 5, 2026
Merged

SirTyson merged 1 commit into
stellar:mainfrom
SirTyson:ungate-ms-close-time

Conversation

@SirTyson

@SirTyson SirTyson commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Remove build def from MS time XDR changes for protocol 30 release.

Remove the #ifdef MS_CLOSE_TIME preprocessor gating so CAP-0088's
millisecond close time XDR (the STELLAR_VALUE_SIGNED_MS and
STELLAR_VALUE_EMPTY_TX_SET_MS StellarValue arms and the TimePointMs
typedef) is unconditionally present on main, and therefore lands in
curr as well as next. Folds the gated leading comma in the
StellarValueType enum back onto the preceding line.
Copilot AI lite review requested due to automatic review settings October 5, 2026 17:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review comments were identified.

Review effort: Lite
Findings: None

What changed in this PR

This pull request ungates CAP-0088 millisecond close-time XDR definitions without changing the wire format.

Changes:

  • Makes TimePointMs unconditional.
  • Makes millisecond StellarValue variants and union arms unconditional.
File Summary
Stellar-types.x Makes TimePointMs unconditional.
Stellar-ledger.x Ungates millisecond StellarValue definitions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@SirTyson
SirTyson requested a review from anupsdf October 5, 2026 17:59
@SirTyson
SirTyson merged commit b77bea0 into stellar:main Oct 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants