Skip to content

Rename TimePointMilliseconds to TimePointMs - #319

Merged
SirTyson merged 1 commit into
stellar:mainfrom
SirTyson:rename-timepointms
Oct 2, 2026
Merged

SirTyson merged 1 commit into
stellar:mainfrom
SirTyson:rename-timepointms

Conversation

@SirTyson

@SirTyson SirTyson commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #317, tracking the CAP-0088 update in stellar/stellar-protocol#2023, which renamed the millisecond close-time typedef from TimePointMilliseconds to TimePointMs.

Changes:

  • Stellar-types.x: typedef uint64 TimePointMilliseconds → typedef uint64 TimePointMs.
  • Stellar-ledger.x: the closeTimeMs field in both STELLAR_VALUE_SIGNED_MS and STELLAR_VALUE_EMPTY_TX_SET_MS now uses TimePointMs.

Only the name changes. The wire format is the same (uint64 milliseconds since the Unix epoch), and everything is still gated behind MS_CLOSE_TIME, so curr is untouched.

Core-side implementation: stellar/stellar-core#5423.

🤖 Generated with Claude Code

Copilot AI lite review requested due to automatic review settings October 2, 2026 19:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review issues; the changes preserve wire format and feature gating.

Review effort: Lite
Findings: None

What changed in this PR

Renames the gated millisecond timestamp typedef to match CAP-0088 while preserving the XDR wire format.

Changes:

  • Renamed TimePointMilliseconds to TimePointMs.
  • Updated both closeTimeMs fields.
  • Preserved MS_CLOSE_TIME gating.
File Description
Stellar-types.x Renames the millisecond timestamp typedef.
Stellar-ledger.x Updates both millisecond close-time fields.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

CAP-0088 renamed the millisecond close-time typedef from
TimePointMilliseconds to TimePointMs (stellar/stellar-protocol#2023).
Wire format is unchanged: it is still a uint64 of milliseconds since
the Unix epoch, gated behind MS_CLOSE_TIME.
@SirTyson
SirTyson force-pushed the rename-timepointms branch from 4b73c36 to 141761b Compare October 2, 2026 19:57
@SirTyson
SirTyson requested a review from anupsdf October 2, 2026 19:58
@SirTyson
SirTyson enabled auto-merge (squash) October 2, 2026 20:02
@SirTyson
SirTyson merged commit 4f3303c into stellar:main Oct 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants