Skip to content

Point stellar-xdr at the P30-ungated rev - #28

Merged
sisuresh merged 2 commits into
stellar:mainfrom
sisuresh:bump-stellar-xdr-p30-ungated
Oct 7, 2026
Merged

sisuresh merged 2 commits into
stellar:mainfrom
sisuresh:bump-stellar-xdr-p30-ungated

Conversation

@sisuresh

@sisuresh sisuresh commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Repins stellar-xdr to stellar/rs-stellar-xdr#606 (merged as 28f34cf, ungates CAP-0084/CAP-0087) so stellar-core's checkXDRFileIdentity matches the p30 host in stellar/stellar-core#5478.

https://claude.ai/code/session_01MUfDZLWtSNdpoFYK9XVeHs

Repins rs-stellar-xdr to stellar/rs-stellar-xdr#606 (4cf1cef), which ungates
CAP-0084 and CAP-0087, so stellar-core's XDR identity check matches the p30
soroban host.

Claude-Session: https://claude.ai/code/session_01MUfDZLWtSNdpoFYK9XVeHs
@sisuresh
sisuresh marked this pull request as ready for review October 7, 2026 17:52
Copilot AI lite review requested due to automatic review settings October 7, 2026 17:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The dependency and lockfile revisions are synchronized with no unresolved issues.

0 open findings

What changed in this PR

Repins stellar-xdr to the merged P30-compatible revision 28f34cf.

Changes:

  • Updates the dependency revision in Cargo.toml.
  • Synchronizes the locked revision in Cargo.lock.
File Description
Cargo.toml Updates the stellar-xdr revision.
Cargo.lock Records the matching resolved revision.

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@sisuresh
sisuresh merged commit 811d19a into stellar:main Oct 7, 2026
6 checks passed
sisuresh added a commit to sisuresh/stellar-core that referenced this pull request Oct 7, 2026
stellar/stellar-xdr#321 (4f524bb), stellar/rs-soroban-env#1745 (ca1e609) and
stellar/stellar-quorum-analyzer#28 (811d19a), all on rs-stellar-xdr#606
(28f34cf). Same trees as the PR heads, so golden data is unchanged.

Claude-Session: https://claude.ai/code/session_01MUfDZLWtSNdpoFYK9XVeHs
sisuresh added a commit to sisuresh/stellar-core that referenced this pull request Oct 8, 2026
Bumps CURRENT_LEDGER_PROTOCOL_VERSION to 30 (adding V_31 for vnext) and
promotes the p30 host to current: built unconditionally, soroban_curr, and
given --features=next in vnext builds so it reports 31 (routed to p30_cache).
fastdev keeps only the two latest hosts, now p29 and p30.

Ungates CAP-0084 and CAP-0087: removes the CAP_0084_MUXED_CONTRACT and
CAP_0087_ML_DSA ifdefs and their configure.ac / common.mk / Makefile.am /
cppFeatures wiring, and creates the ML-DSA cost types 86-94 at the v30
upgrade. Pins XDR to stellar/stellar-xdr#321, the p30 host to
stellar/rs-soroban-env#1745 and the quorum analyzer to
stellar/stellar-quorum-analyzer#28, all on stellar/rs-stellar-xdr#606, so
checkXDRFileIdentity passes.

Claude-Session: https://claude.ai/code/session_01MUfDZLWtSNdpoFYK9XVeHs
sisuresh added a commit to sisuresh/stellar-core that referenced this pull request Oct 8, 2026
Bumps CURRENT_LEDGER_PROTOCOL_VERSION to 30 (adding V_31 for vnext) and
promotes the p30 host to current: built unconditionally, soroban_curr, and
given --features=next in vnext builds so it reports 31 (routed to p30_cache).
fastdev keeps only the two latest hosts, now p29 and p30.

Ungates CAP-0084 and CAP-0087: removes the CAP_0084_MUXED_CONTRACT and
CAP_0087_ML_DSA ifdefs and their configure.ac / common.mk / Makefile.am /
cppFeatures wiring, and creates the ML-DSA cost types 86-94 at the v30
upgrade. Pins XDR to stellar/stellar-xdr#321, the p30 host to
rs-soroban-env main (8abed90, after stellar#1745/stellar#1746) and the quorum analyzer to
stellar/stellar-quorum-analyzer#28, all on stellar/rs-stellar-xdr#606, so
checkXDRFileIdentity passes.

Claude-Session: https://claude.ai/code/session_01MUfDZLWtSNdpoFYK9XVeHs
SirTyson pushed a commit to SirTyson/stellar-core that referenced this pull request Oct 9, 2026
Bumps `CURRENT_LEDGER_PROTOCOL_VERSION` to 30 and promotes the p30 host
to current (vnext builds it with `next`, reporting 31). Ungates CAP-0084
and CAP-0087 in core: merges in stellar#5455 (CAP-0087 cost
types/upgrade/tests), removes the `CAP_0084_MUXED_CONTRACT` /
`CAP_0087_ML_DSA` ifdefs and build wiring, and re-enables
`checkXDRFileIdentity`. Baselines, LCM goldens and protocol 30/31 LCM
reference files re-recorded.

Pins (all merged): XDR stellar/stellar-xdr#321, p30 host
stellar/rs-soroban-env#1745, quorum analyzer
stellar/stellar-quorum-analyzer#28, all on stellar/rs-stellar-xdr#606.

https://claude.ai/code/session_01MUfDZLWtSNdpoFYK9XVeHs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants