Skip to content

harden: add URL validation in index.ts (CWE-918) #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: main
Choose a base branch
from
Open

harden: add URL validation in index.ts (CWE-918) #345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/vault/controller/connections/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,12 @@ class ConnectionController {
invokeRequest.pathParams,
invokeRequest.queryParams,
);
// Ensure that substituting user-controlled pathParams/queryParams did not
// change the request's destination (host/origin), preventing SSRF via
// injected values such as "@evil.com" or "../" in a path param.
if (new URL(filledUrl).origin !== new URL(this.client.url).origin) {
throw new Error("Invalid connection URL: destination origin mismatch");
}
getBearerToken(this.client.getCredentials(), this.logLevel)
.then((token) => {
printLog(
Expand Down