Conversation
The connections controller dynamically constructs URLs using fillUrlWithPathAndQueryParams() with user-controlled pathParams and queryParams, then passes the result to fetch() without validating the final URL Addresses CWE-918
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The connections controller dynamically constructs URLs using fillUrlWithPathAndQueryParams() with user-controlled pathParams and queryParams, then passes the result to fetch() without validating the final URL. While the base URL is validated via isValidURL(), the path and query parameter injection could manipulate the request destination. This is defence-in-depth at
src/vault/controller/connections/index.ts:236rather than a vulnerability I can show is exploitable here — it makes the failure mode explicit and bounded. Close it freely if the pattern is intentional.Reference: CWE-918
What changed
src/vault/controller/connections/index.tsVerification
No automated check could be run against this repository, so this change is unverified beyond review. Please treat it as a suggestion.