Repository navigation
feat: add Relay themes and a theme provider - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by mau
Before: relay-cards (
theme), relay-chat (ChatTheme) and relay-shell (ShellTheme) each defined the Relay palette, with slightly different values for green, red and yellow and different names for the same roles.After: relay-ui exports one
Themewith named roles (accent,focus,success,warning,danger,muted,rule, surfaces),relayThemeandmonoTheme,defineThemeto override a few colors,resolveThemefor--themeflags, andThemeProvider/useThemeso components pick up the theme without a prop.relay-ui --theme monoshows the gallery in either theme.Where the three repos disagreed, the values follow relay-chat and relay-shell (danger
#FF4D5A, warning#F0C84B) and relay-shell's green#4FD18B. relay-cards will see slightly different shades when it migrates.How:
src/theme/holds the palette, the provider and aSwatcheslist used by the gallery. Stacked on #1; the diff shrinks to this commit once #1 is merged.