Repository navigation
feat: add a themed spinner with done and failed states - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by mau
Before: neither relay-cards nor relay-chat had a spinner. relay-chat shows a static
Thinking…while a reply streams, and relay-cards shows a running process only as a colored state word.After:
Spinneranimates in the theme's accent color with an optional label, offersdots,lineandpulsestyles or custom frames, and switches to a green ✓ or red ✗ whenstatebecomesdoneorfailed, which also stops its timer.useSpinnerFramegives the current frame to tools that draw the spinner inside their own text. The gallery shows all five forms.How: one
setIntervalper running spinner, cleared on finish and unmount. Single-frame renders such asrenderToStringshow the first frame. Stacked on #2; merge after it.