Skip to content

Make the header menu separators solid #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamjohnwright merged 2 commits into from
Sep 21, 2026
Merged

Make the header menu separators solid #287

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8226ef6
Make the header menu separators solid
adamjohnwright Sep 21, 2026
0bcfd53
Merge branch 'main' into fix/header-menu-separators
adamjohnwright Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions projects/website-angular/src/app/navigation-bar/navigation-bar.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,18 @@ $hamburger-breakpoint: 1100px;

.dropdown-item {
margin: 0;
border-bottom: 1px dashed var(--outline);
// Solid, not dashed. A dashed rule reads as a placeholder or an editable
// field rather than as a divider, which is what a reviewer picked up on --
// and at 1px the dashes are what the eye lands on instead of the labels.
border-bottom: 1px solid var(--outline);
position: relative;

// No rule under the last one: it drew a line across the bottom of the menu
// with only the list's padding beneath it, which reads as a divider above
// something that is not there.
&:last-child {
border-bottom: none;
}
}

.dropdown-link {
Expand Down Expand Up @@ -256,7 +266,11 @@ $hamburger-breakpoint: 1100px;

.nested-dropdown-item {
margin: 0;
border-bottom: 1px dashed var(--outline);
border-bottom: 1px solid var(--outline);

&:last-child {
border-bottom: none;
}
}

.nested-dropdown-link {
Expand Down
Loading