Make the header menu separators solid - #287
Merged
Merged
Conversation
Review feedback: the dashed lines between dropdown items were not liked, and the reason they stand out is that a dashed rule reads as a placeholder or an editable field rather than as a divider. At 1px the dashes are what the eye lands on instead of the labels. Solid, same colour and weight, so the menu still groups but the separator stops announcing itself. Also removed the rule under the last item in each list, which drew a line across the bottom of the menu with only the list's padding beneath it -- a divider above nothing. That was there before and is the kind of thing that reads as "something is missing below". Desktop only in effect: the mobile breakpoint already removed the nested border, and the top-level bar has no separators at all. Verified by compiling the stylesheet: no dashed rules remain, both borders are solid, and both last-child exceptions are emitted. If the feedback meant no lines at all rather than not-dashed, that is deleting two declarations -- say so and I will. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review feedback: the dashed lines between header dropdown items were not liked.
The reason they stand out is that a dashed rule reads as a placeholder or an editable field rather than as a divider — at 1px, the dashes are what the eye lands on instead of the labels.
Now solid, same colour and weight, so the menu still groups but the separator stops announcing itself.
Also fixed
The rule under the last item in each list, which drew a line across the bottom of the menu with only the list's padding beneath it — a divider above nothing. Pre-existing, and the kind of thing that reads as "something is missing below".
Scope
Desktop only in effect: the mobile breakpoint already removed the nested border, and the top-level bar has no separators at all.
Verified by compiling the stylesheet rather than by reading it — no dashed rules remain, both borders are solid, both
:last-childexceptions are emitted.If the feedback meant something stronger
If "didn't like the dotted lines" meant no lines at all rather than not dashed, that is deleting two declarations. Say the word.
🤖 Generated with Claude Code