Repository navigation
Theme families: Ayu, Kanagawa, Everforest, Flexoki, Night Owl (#401) - #418
Merged
Merged
Conversation
Twelve variants with colors copied exactly from each project's MIT-licensed source at a recorded revision (sources, revisions, licenses and role mapping in docs/design/theme-families.md). Every role fill keeps 4.5:1 module text contrast; light variants keep NMSh's text tiers. Existing ids and saved choices are unchanged; Lavender stays the default. Oxocarbon (grays computed at runtime in HSLuv), GitHub Primer (values from a built primitives release), Material/Palenight and Monokai (licensing not verified) are deferred with reasons. Theme Studio's Built-in list gains / to filter by name, family or dark/light; Esc clears the filter before closing.
31 tasks
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #417 (modules) → #416 → #415 → #414 → #413 → #412 → #411. Merge in order.
What
Twelve bundled variants in five new families, all from MIT-licensed upstream sources pinned to a commit. Values were extracted from the raw files, not from memory or summaries. Sources, revisions, licenses (copyright lines read from each LICENSE) and the role mapping are in
docs/design/theme-families.md.themes/*.yaml(d461f029): base palette, editor/UI fg, panel bg, accent tint, errorcolors.lua+themes.lua(bb85e4bf): each theme's own fun/keyword/string/type/identifier/bg_p2/nontext/comment/bg_visual/ok/errorpalette.md(85a86eb6)/to filter by name, family ordark/light(each word must match). Enter keeps the filter, and Esc clears it before Esc closes. Text typed into the filter never triggers the Chroma toggle.Deferred, with reasons
@primer/primitivesrelease, not from the theme repository.#336
The editor's dialogs (#414) already use the existing action-control renderer. No other v0.21 surface needed a new control, so nothing else was consolidated (noted in the ledger).
Tests
themeFamilies.test.ts: the new family ids and variant names; spot checks against the upstream files; the filter's behavior. The existing per-variant tests (valid hex, 4.5:1 contrast on every fill, distinct adjacent fills, light variants keep text tiers) cover all twelve.Not verified
Physical checks:
docs/testing/v021-physical-qa.mdsection 7 (dark and light terminals, 256-color,NO_COLOR, host untouched). Not run.Refs #401, #336, #410