Repository navigation
Markets in every morning: S&P 500 and Dow fallback - #18
Open
pythonjeff wants to merge 6 commits into
Open
pythonjeff wants to merge 6 commits into
pythonjeff wants to merge 6 commits into
Conversation
The route was written before the package move and its lazy import was not converted, so it 500'd in production. Adds a route-level test. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The live-scores offer block joined sports_teams as strings; a profile with dicts there raised in _build_system, failing every reply and the morning text for that user. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
home._fetch_prices falls back to the broad market only when nothing in the user's topics resolved to a symbol (and they have not hidden Markets); the morning text now requires a MARKETS bullet whenever there is a price row. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users who follow no ticker now get the S&P 500 and Dow in Markets (page and text); the morning text requires a MARKETS bullet whenever a price row exists. Fallback applies only when no topic resolved to a symbol, never when tracked tickers merely fail to fetch, and not when the user hid Markets. Tests added (1444 pass). Not deployed yet. 🤖 Generated with Claude Code