Skip to content

fix(simulate): bare lk agent simulate runs a text simulation again #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
u9g wants to merge 1 commit into from
Closed

fix(simulate): bare lk agent simulate runs a text simulation again #1043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions cmd/lk/simulate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,20 @@ const (
)

var simulateCommand = &cli.Command{
Name: "simulate",
Aliases: []string{"simulation"},
Usage: "Run judged simulations of an agent on LiveKit Cloud",
Name: "simulate",
Aliases: []string{"simulation"},
Usage: "Run judged simulations of an agent on LiveKit Cloud",
ArgsUsage: "[entrypoint]",
// Hide the implicit `help` subcommand so shell completion falls back to
// native filename completion for the entrypoint arg (see startCommand).
HideHelpCommand: true,
// Bare `simulate` is `simulate text`: docs, the dashboard and published
// posts all tell users to run it without a subcommand.
Action: func(ctx context.Context, cmd *cli.Command) error {
return cli.ShowSubcommandHelp(cmd)
if _, err := loadSimulateProject(ctx, cmd); err != nil {
return err
}
return runSimulate(ctx, cmd, livekit.SimulationMode_SIMULATION_MODE_TEXT)
},
Commands: []*cli.Command{
simulateTextCommand, simulateAudioCommand, simulateListCommand, simulateViewCommand, simulateExportCommand,
Expand Down
Loading