Repository navigation
Conversation
#968 made bare `lk agent simulate` print help, but the dashboard's empty state (`lk agent simulate -n 5`), the launch blog post (`lk agent simulate -n 10`), the product page and the dashboard's generated CI workflow all tell users to run it without a subcommand. Every one of those first runs ends at a help screen instead of a simulation. Restore the pre-#968 behavior: with no subcommand, `simulate` runs `simulate text`.
Contributor
Author
|
Closing: we're keeping the explicit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since #968 (v2.18.8 onward), running
lk agent simulatewithout a subcommand only prints help. But that's exactly what every getting-started surface tells users to run:lk agent simulate -n 5lk agent simulate -n 10lk agent simulatefrom your agent's directory"lk agent simulate --scenarios scenarios.yaml ...So a new user's first attempt ends at a help screen instead of a simulation. This happens at the funnel's largest drop-off: since Sep 6, ~9.4k projects opened the Simulations page and ~0.9k ran a simulation.
Fix
Restore the pre-#968 behavior: with no subcommand,
simulaterunssimulate text. Subcommands (text,audio,list,view,export,cancel) are unchanged.Verification
go test ./cmd/lk/passes.agent-starter-pythoncheckout against a staging project,lk agent simulate -n 2 -ystarts the agent, generates 2 scenarios, runs them and prints the summary and dashboard link (before this change it printed help).