Repository navigation
site-deploy: write version.json with the commit pre-build - #70
Conversation
Adds an optional version_file input (default public/version.json) and a step that writes sha, repo, built_at and run_url so sites expose the deployed commit. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe site deployment workflow adds an optional ChangesSite version metadata
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to This change adds an optional version.json file written before the site build, and an empty input disables it. Its main remaining uncertainty is that it has not yet been run in a real caller workflow, which is normal validation before the release is cut. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change exposes commit, repository, and run identifiers after callers upgrade, without adding cloud permissions. No introduced security finding was established, but caller-specific publication, confidentiality, and rollback behavior remain unvalidated. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Hardening Proposals
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Closes #69
Adds an optional
version_fileinput (defaultpublic/version.json, empty disables) tosite-deploy.yml. A new step after checkout, before the pre-build command and Astro build, writes{sha, repo, built_at, run_url}withjq -n. Astro servespublic/verbatim, so each calling site exposes its deployed commit at/version.json, letting a probe check whether the live site matches the newestmain.Also documents the input in the workflow header and README, and adds a CHANGELOG (new file) entry under v1.3.0 (new optional input, so minor).
Notes:
jqcommand emits valid JSON; not yet run in a real caller workflow.🤖 Generated with Claude Code