feat(graph): add the document-vector read seam for revision candidates (#1014) - #1055
Merged
Merged
Conversation
… blocking (#1014) Adds VectorStoreDB.document_vectors, a JOIN of doc_vectors and vector_meta keyed by concept id, and promotes reindex.embedding_tag to a public function that _effective_model_tag now delegates to. Together these let a future reader (openkos revisions) compare a Decision's current content hash against its stored vector without ever embedding itself, per design.md Decision B1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 4 of the
decision-revision-detectorchain, which is Phase B slice P1 (stacked-to-main).reindexalready stores invectors.db, andrevisionsnever calls an embedder. The subject pass is dropped (owner decision B3).--include-confidentialdoes not authorize an embed call (owner decision B2). The spec and design deltas are updated and the Phase B tasks are written (11 slices).VectorStoreDB.document_vectors(concept_ids)returnsStoredDocVectorrows (vector + content hash) by joiningdoc_vectorsandvector_meta. It is concrete-store only and deliberately not on theVectorStoreProtocol, following the precedent ofneighbors.embedding_tag(model)instate/reindex.py;_effective_model_tagdelegates to it.Nothing is wired to a verb yet; the seam is inert until P5.
Related issue
Refs #1014
Type of change
feat— new featuredocs— documentation onlyHow was this tested?
AttributeErroron the missing method and function). 5 mutations were run: 4 were killed. The 5th, removing the empty-input guard, survives because SQLite'sIN ()matches no rows anyway; the guard is kept as a query-avoidance shortcut.ruff check .,ruff format --check .andmypy .are clean;pytest --cov6823 passed, 97.07% coverage;evals/run_self_tests.py43 of 43.Checklist
ruff,mypy,pytest).