Skip to content

feat: compile-check compiles only the dependents that use what a public API change touched #3348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hatayama merged 4 commits into from
Oct 16, 2026
Merged

feat: compile-check compiles only the dependents that use what a public API change touched #3348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b9c953
feat: compile-check skips dependents that write none of the names a c…
hatayama Oct 16, 2026
852898b
docs: compile-check says changes to well-known types compile every de…
hatayama Oct 16, 2026
3953915
fix: compile-check reads saved generator output before any compile ca…
hatayama Oct 16, 2026
1d6172a
test: compile-check pins reading generator output before the backgrou…
hatayama Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions cli/dispatcher/internal/compilecheck/compiler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ type UnitResult struct {
// WaitedForRecord marks a unit that waited for the references still compiling rather than
// starting before them, because its recorded result might be replayed once they finished.
WaitedForRecord bool
// ChangedReferences names the referenced assemblies whose changed surface counted for this unit,
// in the plan's order, each with the first changed name the unit writes.
ChangedReferences []ChangedReference
}

// CommandRunner runs one compiler invocation, so tests can stand in for the real process.
Expand All @@ -109,14 +112,14 @@ type Compiler struct {
// compareSurface stands in for the comparison of a unit's reference assembly with Unity's; nil
// compares the two. Why it can be replaced: the tests have to see which units the run compares at
// all, and a byte comparison leaves nothing behind to count.
compareSurface func(projectRoot string, plan BuildPlan, unit CompileUnit) bool
compareSurface func(projectRoot string, plan BuildPlan, unit CompileUnit) SurfaceVerdict
}

// surfaceVerdict says whether compiling this unit left its reference assembly showing its dependents
// the public surface the last Unity build showed them.
func (c Compiler) surfaceVerdict(ctx context.Context, plan BuildPlan, unit CompileUnit) SurfaceVerdict {
if c.compareSurface != nil {
return SurfaceVerdict{Kept: c.compareSurface(c.ProjectRoot, plan, unit)}
return c.compareSurface(c.ProjectRoot, plan, unit)
}

return c.referenceSurfaceVerdict(ctx, plan, unit)
Expand Down
Loading
Loading